Tolerate duplication in p2p negotiation batches#11878
Merged
YuliiaKovalova merged 1 commit intoOct 27, 2025
Merged
Conversation
The intent of batching over the condition
'@(ProjectsWithNearestPlatform)' == '%(Identity)'
is to run the update for each item in the list (that meets the rest of
the condition).
However, if there are two list entries with identical `%(Identity)`--in
this case duplicate ProjectReferences--they batch into the same bucket
and then that condition is `false`.
Instead, batch over unique identities to tolerate duplicates.
Fixes dotnet#2688.
Co-Authored-By: Benjamin Witman <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates MSBuild batching logic to process each project reference individually, tolerating duplicates by switching from list-based to metadata-based conditions.
- Switched
<ProjectsWithNearestPlatform>conditions to use%(Identity)metadata checks instead of comparing the entire item list. - Updated
<AnnotatedProjects>conditions similarly for NearestTargetFramework, single-target checks, and RID agnosticism.
rainersigwald
commented
May 21, 2025
ghost
requested a review
from 
ghost
assigned
YuliiaKovalova
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of batching over the condition
is to run the update for each item in the list (that meets the rest of
the condition).
However, if there are two list entries with identical
%(Identity)--inthis case duplicate ProjectReferences--they batch into the same bucket
and then that condition is
false.Instead, batch over unique identities to tolerate duplicates.
Fixes #2688.