Conversation
SimaTian
force-pushed
the
refactor_expander_basic
branch
from
277798f to
9a3b07b
Compare
SimaTian
force-pushed
the
refactor_expander_basic
branch
from
7020f78 to
f5a141d
Compare
SimaTian
force-pushed
the
refactor_expander_basic
branch
from
7705860 to
9991790
Compare
maridematte
approved these changes
Jan 15, 2025
MichalPavlik
approved these changes
Jan 16, 2025
surayya-MS
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracting the TryExecuteWellKnownFunction and argument parsing to a separate file.
Fixes #9975
partial fix at best. Extracting the area into separate files. Further refactoring unfortunately had a performance impact so I've settled for containing the ugly area.
Context
TryExecuteWellKnownFunction is MSBuild performance hack to avoid reflection since it's slow.
Together with argument parsing, this is some 1500 lines of code that was in the Expander.cs making it hard to navigate.
Testing
existing tests should be sufficient as I did no changes to the logic and just moved stuff around. There were some rough edges that I had to clean but I hope our current test battery will be sufficient.
Notes
We should look into Reflection.Emit, custom IL generation could be a way to get rid of this hack in a performant manner. I'll add it on my to-learn list for Fridays.