Merged
Conversation
JanKrivanek
force-pushed
the
proto/copyalways-check
branch
from
8ade309 to
83099b9
Compare
Co-authored-by: Rainer Sigwald <[email protected]>
maridematte
approved these changes
Dec 9, 2024
rainersigwald
approved these changes
Dec 10, 2024
donJoseLuis
approved these changes
Dec 11, 2024
| * `PreserveNewest` | ||
| * `IfDifferent` | ||
|
|
||
| `Always` is not recommended, as it causes the files to be copied in every build, even when the destination file content is identical to the source. |
There was a problem hiding this comment.
given that it is not recommended; should it be listed last?
| public override IReadOnlyList<CheckRule> SupportedRules { get; } = [SupportedRule]; | ||
|
|
||
| public override void Initialize(ConfigurationContext configurationContext) | ||
| { |
There was a problem hiding this comment.
bodyless inherited method; by design?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7654
Context
Adding a check validating that
Alwaysis not being used forCopyToOutputDirectorymetadata. Or that theSkipUnchangedFilesOnCopyAlwaysproperty is set toTrueto avoid unnecessary copying.Testing
Tailored tests added - covering as well the #11052