Skip to content

EmbeddedResource Culture Check#11023

Merged
JanKrivanek merged 7 commits into
mainfrom
proto/embeddedresource-check
Nov 27, 2024
Merged

EmbeddedResource Culture Check#11023
JanKrivanek merged 7 commits into
mainfrom
proto/embeddedresource-check

Conversation

@JanKrivanek

@JanKrivanek JanKrivanek commented Nov 22, 2024

Copy link
Copy Markdown
Member

Fixes #9882, #9154

Context

This is the initial implementation of the EmbeddedResourceCheck class, which is a built-in analyzer that checks for the presence of the Culture metadata in EmbeddedResource items.

Testing

Tailored tests

Comment thread src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs

@surayya-MS surayya-MS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment thread documentation/specs/BuildCheck/Codes.md Outdated
Comment thread src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs
Comment thread src/BuildCheck.UnitTests/EndToEndTests.cs
Comment thread src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs Outdated
Comment thread src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs Outdated
Comment thread src/Shared/StringExtensions.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Built-in analyzer] EmbeddedResource item is missing the Culture metadata

4 participants