Enable xunit2020 rule with severity=warning#10587
Merged
f-alizada merged 1 commit intodotnet:mainfrom Sep 2, 2024
Merged
Conversation
MichalPavlik
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10586
Context
During the retargeting work from net8 to net9 new tools brought new rules and warnings to the build. Not to introduce a lot of changes in one PR the rules were disabled.
This PR enables one of them
xunit2020https://xunit.net/xunit.analyzers/rules/xUnit2020 and addresses the issuesChanges Made
Find -> Replace
Assert.True(false, -> Assert.Fail(Assert.True(false) -> Assert.Fail()Testing
Existing tests should be green
Notes