Test Verification Report

Date: 2026-04-26 04:25:25 | Platform: CATALYST | Status: ✅ PASSED

Summary

✅ Final Verdict

VERIFICATION PASSED ✅

The tests correctly detect the issue:

• ✅ Tests FAIL without the fix (as expected - bug is present)
• ✅ Tests PASS with the fix (as expected - bug is fixed)

Conclusion: The tests properly validate the fix and catch the bug when it's present.

Configuration

Platform: catalyst
Test Filter: Issue35005
Base Branch: main
Merge Base: d5e39b0

Fix Files

• src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

Test Results Details

Test Run 1: WITHOUT Fix

Expected: Tests should FAIL (bug is present)
Actual: Tests FAILED ✅

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 700 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 4.67 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 5.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 5.17 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 5.29 sec).
  1 of 11 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Maps.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-maccatalyst26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Foldable.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-maccatalyst/maccatalyst-x64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-maccatalyst/maccatalyst-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:01:16.34

Test Run 2: WITH Fix

Expected: Tests should PASS (bug is fixed)
Actual: Tests PASSED ✅

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-maccatalyst26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-maccatalyst26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-maccatalyst/maccatalyst-x64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  ##vso[build.updatebuildnumber]10.0.70-ci+azdo.13940074
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-maccatalyst/maccatalyst-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:01:17.31

Logs

• Full verification log: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/PRState/35008/PRAgent/gate/verify-tests-fail/verification-log.txt
• Test output without fix: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/PRState/35008/PRAgent/gate/verify-tests-fail/test-without-fix.log
• Test output with fix: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/PRState/35008/PRAgent/gate/verify-tests-fail/test-with-fix.log
• UI test logs: CustomAgentLogsTmp/UITests/

Detected UI test categories: Shell

Issue: #35005 - [iOS&Mac] Shell SearchHandler Query not shown in search bar on initial load
PR: #35008 - [iOS&Mac] Fix Shell SearchHandler Query update on Initial load
Platforms Affected: iOS, macCatalyst
Files Changed: 1 implementation, 2 test

Key Findings

• Root cause: AttachSearchController() in ShellPageRendererTracker.cs initialized searchBar.Placeholder but not searchBar.Text, so any Query set before page load was silently discarded
• Fix: one-line addition searchBar.Text = SearchHandler.Query; right after searchBar.Placeholder = SearchHandler.Placeholder; in AttachSearchController()
• Android is not affected (already sets Text during initialization in ShellSearchView.cs)
• Windows: unknown – not tested by author (PR in draft), unrestricted UI test will run there
• Re-navigation safety: AttachSearchController() is called on every SearchHandler re-set (tab switch), so fix is idempotent
• No feedback loop: UIKit does not fire UISearchResultsUpdating when UISearchBar.Text is set programmatically

Code Review Summary

Verdict: NEEDS_DISCUSSION
Confidence: high
Errors: 0 | Warnings: 2 | Suggestions: 1

Key code review findings:

• ⚠️ src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35005.cs — Test runs on all platforms including Windows, but Windows device tests weren't verified; could fail if Windows has the same bug
• ⚠️ PR is still in draft; maui-pr-devicetests CI has not run; device-test confirmation needed before merge
• 💡 src/Controls/tests/TestCases.HostApp/Issues/Issue35005.cs:3 — PlatformAffected.iOS should also include macOS (fix applies to MacCatalyst too)

Fix Candidates

Code Review — PR #35008

Independent Assessment

What this changes: Adds a single line searchBar.Text = SearchHandler.Query; in AttachSearchController() in ShellPageRendererTracker.cs, alongside the existing searchBar.Placeholder = SearchHandler.Placeholder; assignment. Adds a HostApp page and a UI test that verifies the pre-set query value appears in the search bar on page load.

Inferred motivation: The UISearchBar was initialized with the Placeholder but not the initial Query value, so any Query set before the page loaded would be silently lost.

Reconciliation with PR Narrative

Author claims: Bug fix for SearchHandler.Query not displayed on iOS/MacCatalyst at load time; includes new UI test coverage; tested on iOS and Mac only (Windows/Android unchecked, PR is draft).

Agreement: Assessment matches the author's description. The fix location and approach are correct. Android sets the initial query text already (line 197 in ShellSearchView.cs), which is consistent with Android not being listed as affected.

Discrepancy: The PlatformAffected.iOS in the [Issue] attribute on the HostApp page should include macOS since the fix applies to MacCatalyst (this file lives in the iOS compatibility layer but compiles for both). Minor metadata issue only.

Findings

⚠️ Warning — UI test has no platform restriction, but Windows hasn't been verified

File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35005.cs

The test will run on all platforms (Android, iOS, MacCatalyst, Windows) since there's no [Category(UITestCategories.IsNotRunningOnXxx)] guard. This is correct per MAUI convention ("UI tests must run on all applicable platforms"). However, Windows was unchecked in the PR's test matrix, and GetShellSearchHandler() on Windows uses app.WaitForElement("TextBox") which relies on finding the Shell search TextBox by class name. If the Shell SearchHandler on Windows does not pre-populate Query at initial load (the same class of bug), this test will fail on Windows device tests.

Android has been verified safe: ShellSearchView.cs:197 already sets Text = query during initialization.

Recommendation: Before removing the draft status, run Windows device tests or add a code comment explaining why Windows passes. If Windows also has this bug, a separate fix in the Windows Shell handler is needed.

⚠️ Warning — Device tests not yet triggered (PR is draft)

The maui-pr build CI is green, but maui-pr-devicetests has not run. Since the fix is in iOS/macCatalyst rendering code and the primary verification is a UI test, device test CI should pass before merge. The PR should be marked ready-for-review only after device tests are confirmed green.

💡 Suggestion — PlatformAffected.iOS is incomplete for MacCatalyst

File: src/Controls/tests/TestCases.HostApp/Issues/Issue35005.cs:3

[Issue(IssueTracker.Github, 35005, "...", PlatformAffected.iOS)]

The fix applies to MacCatalyst as well (same ShellPageRendererTracker.cs is used). The annotation should be:

[Issue(IssueTracker.Github, 35005, "...", PlatformAffected.iOS | PlatformAffected.macOS)]

PlatformAffected is metadata only and doesn't affect test execution, but accuracy helps future triage.

Devil's Advocate

"Is there a side effect from setting searchBar.Text programmatically?"

In UIKit, programmatically setting UISearchBar.Text does not trigger UISearchResultsUpdating.UpdateSearchResultsForSearchController, so the SetSearchResultsUpdater callback (which writes back to SearchHandler.QueryProperty) will not fire. No feedback loop risk.

"Does the fix break re-navigation scenarios?"

Shell re-creates the search controller on tab switch by calling AttachSearchController() again after DettachSearchController(). At that point SearchHandler.Query reflects the current value, so re-attaching with searchBar.Text = SearchHandler.Query is correct and idempotent.

"Is there a missing handler for Query property changes after initial load?"

OnSearchHandlerPropertyChanged does not handle QueryProperty — if a binding changes Query after the page is shown, the search bar won't update. This is a pre-existing gap in the iOS implementation (not introduced here) and is out of scope for this PR.

"Could this regress anything?"

The change is strictly additive — one line setting a native property that was previously unset. It cannot break the existing query-empty case (native UISearchBar defaults Text to empty string, so if Query is null or "", the result is the same as before).

Verdict: NEEDS_DISCUSSION

Confidence: high

Summary: The one-line fix is correct, minimal, and in exactly the right place. The adjacent code already initializes Placeholder and icons at the same location, making this a natural and safe change. The two discussion points are: (1) Windows device test coverage is absent — the unrestricted test will run on Windows and may fail if Windows has the same bug, and (2) the PR should not leave draft status until maui-pr-devicetests CI has been run and confirmed green on iOS/MacCatalyst.

Fix Candidates

Cross-Pollination

Exhausted: Yes
Selected Fix: Candidate #1 (try-fix attempt 1) — UpdateSearchBarQuery() helper pattern is architecturally superior as it follows the existing codebase conventions, addresses the initial load bug, AND closes the pre-existing runtime Query-change gap in OnSearchHandlerPropertyChanged. Both Candidate #1 and the PR's fix are correct; Candidate #1 is more complete.

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Code Review Impact on Try-Fix

The code review flagged a pre-existing gap: OnSearchHandlerPropertyChanged does not handle QueryProperty, so programmatic Query changes after initial load aren't synced to the search bar. Attempt 1 (✅ PASS) directly addressed this by adding a UpdateSearchBarQuery() helper wired into both AttachSearchController() and OnSearchHandlerPropertyChanged. This produced a broader, architecturally cleaner fix than the PR's inline approach. Attempt 2 (❌ FAIL) confirmed the code review insight about MacCatalyst's timing sensitivity — text must be set before SearchHandlerAppearanceTracker construction.

Summary

The PR fixes a real and verified bug: on iOS/macCatalyst, SearchHandler.Query set before page load was not displayed in the native UISearchBar because AttachSearchController() initialized searchBar.Placeholder but forgot searchBar.Text. The one-line fix is correct and minimal. However, Try-Fix exploration found a better alternative (Candidate #1) that also closes a pre-existing gap where runtime Query changes after initial load are not reflected in the search bar. The PR should adopt the UpdateSearchBarQuery() pattern. Additionally, two code review warnings should be addressed before removing draft status: (1) Windows device test coverage is unverified, and (2) device tests haven't run on the PR.

Root Cause

AttachSearchController() in ShellPageRendererTracker.cs set searchBar.Placeholder = SearchHandler.Placeholder but never set searchBar.Text = SearchHandler.Query. The UISearchBar was created with no text, discarding the initial query value. Android does not have this bug because ShellSearchView.cs already initializes Text during setup.

Fix Quality

The PR's fix is correct for the reported bug. However, the Try-Fix phase found a stronger alternative: adding a UpdateSearchBarQuery() helper method (following the existing UpdateSearchIsEnabled/UpdateSearchVisibility pattern) and calling it from both AttachSearchController() and OnSearchHandlerPropertyChanged (for QueryProperty). This broadens the fix to also handle the pre-existing gap where programmatic Query changes after load aren't reflected in the search bar. The PR should adopt this pattern.

Additionally:

• [Issue(..., PlatformAffected.iOS)] should be PlatformAffected.iOS | PlatformAffected.macOS to accurately reflect MacCatalyst impact
• Windows device tests should be verified before merge (the test runs on all platforms, and Windows behavior is unconfirmed)
• PR should be taken out of draft only after maui-pr-devicetests CI confirms green on iOS/macCatalyst