-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[ci] Add variable group MAUI #32610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add variable group MAUI #32610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the variable group declarations in the pipeline configuration to make the MAUI variable group unconditionally available instead of being conditionally included based on build definition names.
Key Changes
- The MAUI variable group is moved from conditional inclusion to unconditional inclusion at the top level
|
/backport to release/10.0.1xx-sr1 |
|
Started backporting to |
|
@PureWeen backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 |
Co-authored-by: PureWeen <[email protected]>
…#32781) * Initial plan * Backport PRs #32610, #32694, #32779 - pipeline configuration fixes Co-authored-by: PureWeen <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: PureWeen <[email protected]>
Description of Change
We need a couple of variables from this variable group.
Change other variables to control internal vs public builds.
Small cleanup
This pull request updates build and pipeline configuration files to simplify variable handling, improve conditional logic for build stages, and clean up unused parameters. The primary focus is on streamlining how build arguments and variable groups are set for different build scenarios, including official, public, and internal builds.
Build and variable configuration simplification
_InternalBuildArgsvariable and its assignment fromeng/pipelines/common/variables.yml, and updated how theMAUIvariable group is included to always be present, rather than conditionally. [1] [2]_PublishArgsineng/pipelines/arcade/variables.ymlto use build definition names instead of checking for public/internal builds and pull requests, making the conditions more explicit and maintainable._OfficialBuildIdArgsto an empty value instead of passing parameters, simplifying the official build argument handling.Pipeline cleanup and conditional logic improvements
UseProvisionatorparameter and related provisioning logic fromeng/pipelines/ci-uitests.yml, reducing complexity and potential confusion in test pipeline configuration. [1] [2]Minor fix
Creatorproperty condition ineng/helix.projto check for an existing value before setting a default, preventing unwanted overrides.