Setup testing on dnceng #32297
Merged
Setup testing on dnceng #32297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses build and testing infrastructure issues on the dnceng platform by fixing configurations for source generation unit tests and updating pipeline settings.
- Updated SourceGen.UnitTests project references to remove PrivateAssets restrictions
- Fixed cross-platform string comparison issues in source generation unit tests by normalizing line endings
- Updated CI pipeline configurations to enable Xcode provisioning and improve build environment setup
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/SourceGen.UnitTests/SourceGen.UnitTests.csproj | Removed PrivateAssets="All" from Microsoft.CodeAnalysis package references |
| Multiple SourceGen test files | Added System namespace usage and normalized line endings in string comparisons |
| eng/pipelines/device-tests.yml | Changed skipXcode from true to false |
| eng/pipelines/common/variables.yml | Updated XCODE version from 26.0 to 26.0.1 |
| eng/pipelines/common/run-dotnet-preview.yml | Enhanced environment setup with additional DOTNET variables and logging |
| eng/pipelines/common/provision.yml | Improved Xcode version selection logic and simulator setup |
| eng/pipelines/ci.yml | Enabled Xcode provisioning and added buildscript parameters |
| eng/pipelines/ci-device-tests.yml | New pipeline configuration for device testing |
| eng/pipelines/azure-pipelines-public.yml | Removed entire file |
| eng/pipelines/azure-pipelines-internal.yml | Removed entire file |
| eng/pipelines/arcade/stage-unit-tests.yml | Restructured test execution and removed SourceGen tests from this stage |
| eng/pipelines/arcade/setup-test-env.yml | Enhanced Xcode setup with better version handling |
| eng/helix.proj | Added SourceGen.UnitTests to Helix test execution |
src/Controls/tests/SourceGen.UnitTests/InitializeComponent/WarningIgnore.cs
Show resolved
Hide resolved
src/Controls/tests/SourceGen.UnitTests/InitializeComponent/ResourceDictionary.cs
Show resolved
Hide resolved
# Conflicts: # eng/pipelines/azure-pipelines-public.yml Provision xcode Don t install android stuff Fix script Add device-tests Fix provisioning on xamarin public try again [ci] Fix on dcneng the script too Try 26.0.1 Add sourcegen unit tests to helix Don t use private assets arcade unit tests pass the correct script Try test job publish logs try dotnet test Try fix test Run dotnet test again try again Fix more tests try fix provisioning no need for 2 Try again Log symlinks Pass project Dont force MTP remove project write the command Write path try force more variables Try more variables Fix Skip install simulators Why does this not work try again print info print dir bump timeout again Fix double use of path Skim simulator for device tests Skip on old pipeline too [ci] No need to push device tests results
rmarinho
force-pushed
the
new-unittests
branch
from
53b2f91 to
296011f
Compare
StephaneDelcroix
approved these changes
Nov 1, 2025
PureWeen
added
the
area-infrastructure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix main builds on dnceng