[ci] Update with new pipelines #32264
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI pipeline configuration to introduce separate build pools for internal and public builds, streamline pool parameter definitions, and adjust settings for official builds. The changes ensure proper routing of build jobs based on whether they're triggered by PRs or internal processes.
Key Changes:
- Replaced the single
PackPlatformparameter with separateWindowsPoolandMacOSPoolparameters that define both internal and public pool configurations - Added conditional logic throughout to select appropriate pools and
runAsPublicsettings based on the build definition name - Removed PR-triggered unit tests from the official build pipeline
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/ci.yml | Restructures pool parameters to support internal/public builds, removes internal/release/* branch trigger, and applies conditional pool selection throughout all pipeline stages |
| eng/pipelines/ci-official.yml | Removes PR-triggered unit tests stage and adds enableMicrobuild and publishAssets flags to the pack stage |
| ${{ if eq(variables['Build.DefinitionName'], 'maui-pr') }}: | ||
| helixPool: ${{ parameters.WindowsPool.public }} | ||
| runAsPublic: true | ||
| helixInternal: 'False' | ||
| ${{ else }}: | ||
| helixPool: ${{ parameters.WindowsPool.internal }} | ||
| runAsPublic: false | ||
| helixInternal: 'True' |
There was a problem hiding this comment.
The conditional logic ${{ if eq(variables['Build.DefinitionName'], 'maui-pr') }} is duplicated across multiple stages (helix-tests, pack, build, unit-tests, and template-tests). Consider extracting this to a computed variable or parameter at the top level to reduce duplication and improve maintainability.
|
/backport to net10.0 |
|
Started backporting to |
Description of Change
Update to new pipeline files