[ci] Update release branch for internal builds #32202
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables internal builds on the release branch by configuring access to internal runtime sources and feeds across the build pipeline infrastructure.
Key Changes:
- Added internal runtime source feed configuration with authentication
- Integrated enable-internal-sources and enable-internal-runtimes templates into provisioning and publishing stages
- Added runtime source feed parameters to build scripts
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/common/provision.yml | Adds internal sources and runtimes template steps to the provisioning stage |
| eng/pipelines/arcade/variables.yml | Uncomments and configures _OfficialBuildIdArgs with internal runtime feed URL and authentication |
| eng/common/sdk-task.ps1 | Adds runtimeSourceFeed and runtimeSourceFeedKey parameters to the PowerShell script |
| eng/common/post-build/publish-using-darc.ps1 | Adds runtimeSourceFeed and runtimeSourceFeedKey parameters to the publishing script |
| eng/common/core-templates/post-build/post-build.yml | Adds internal sources/runtimes template steps and passes runtime feed parameters to the publishing script |
| eng/common/core-templates/job/publish-build-assets.yml | Adds internal sources/runtimes template steps and includes runtime feed parameters in the build assets publishing |
| parameters: | ||
| legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw) | ||
| - template: /eng/common/templates/steps/enable-internal-runtimes.yml | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected on line 47. Remove the trailing spaces for consistency with YAML formatting standards.
| - template: /eng/common/templates/steps/enable-internal-sources.yml | ||
| parameters: | ||
| legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw) | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected on line 125. Remove the trailing spaces for consistency with YAML formatting standards.
| /p:MaestroApiEndpoint=https://maestro.dot.net | ||
| /p:OfficialBuildId=$(OfficialBuildId) | ||
| -runtimeSourceFeed https://ci.dot.net/internal -runtimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64) | ||
|
|
There was a problem hiding this comment.
Unnecessary blank line added at line 143. Remove it to maintain consistent formatting in the file.
| -ArtifactsPublishingAdditionalParameters '${{ parameters.artifactsPublishingAdditionalParameters }}' | ||
| -SymbolPublishingAdditionalParameters '${{ parameters.symbolPublishingAdditionalParameters }}' | ||
| -SkipAssetsPublishing '${{ parameters.isAssetlessBuild }}' | ||
| -runtimeSourceFeed https://ci.dot.net/Internal |
There was a problem hiding this comment.
URL casing inconsistency: 'Internal' is capitalized here but lowercase ('internal') in other files (arcade/variables.yml line 54 and publish-build-assets.yml line 142). URLs are case-sensitive and this mismatch will cause authentication failures.
| -runtimeSourceFeed https://ci.dot.net/Internal | |
| -runtimeSourceFeed https://ci.dot.net/internal |
Description of Change
Enable internal builds on release branch.