[XSG] enable diagnostics by default on Debug #32052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default behavior for XAML diagnostics in source generation to enable them by default in Debug builds when not explicitly configured. Previously, diagnostics were disabled unless explicitly enabled; now they default to enabled in Debug and disabled in Release configurations.
Key Changes
- Modified the EnableDiagnostics property logic to check build configuration
- Added explicit true/false checks for EnableMauiXamlDiagnostics before falling back to configuration-based default
- Changed default behavior from false to configuration-dependent (enabled for Debug, disabled for Release)
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/maui/actions/runs/18619327105 |
Member
|
/rebase |
github-actions
bot
force-pushed
the
dev/stdelc/fix32047
branch
from
098a377 to
f22baa2
Compare
StephaneDelcroix
changed the title
mattleibow
previously approved these changes
Oct 23, 2025
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/maui/actions/runs/18751318816 |
if EnableDiagnostics isn't set, defaut to true on Debug builds - fixes #32047
StephaneDelcroix
force-pushed
the
dev/stdelc/fix32047
branch
from
f22baa2 to
54d9fb8
Compare
rmarinho
approved these changes
Oct 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
if EnableDiagnostics isn't set, defaut to true on Debug builds
Issues Fixed