[CV2][iOS] Fix Header/Footer removed at runtime leaves empty space and EmptyView not resized in CollectionView #31916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
jsuarezruiz
added
the
area-controls-collectionview
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Oct 9, 2025
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where removing a header or footer from a CollectionView at runtime on iOS/macOS left empty space that was still being included in EmptyView frame calculations. The fix adds proper cleanup logic to remove the native views when their content is set to null.
- Added cleanup methods in StructuredItemsViewController2 to remove header/footer views when content is null
- Uncommented and activated existing UpdateHeaderView/UpdateFooterView calls in the handler
- Added comprehensive UI test coverage for both removing and adding header/footer at runtime
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Controls/src/Core/Handlers/Items2/iOS/StructuredItemsViewController2.cs |
Added UpdateHeaderView and UpdateFooterView methods to remove native views when content is null |
src/Controls/src/Core/Handlers/Items2/CollectionViewHandler2.iOS.cs |
Uncommented calls to UpdateHeaderView and UpdateFooterView methods |
src/Controls/tests/TestCases.HostApp/Issues/Issue31899.cs |
Added UI test page demonstrating header/footer toggle functionality |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31899.cs |
Added automated tests for header/footer removal and addition scenarios |
Comment on lines
+74
to
+80
| return new Label | ||
| { | ||
| TextColor = Colors.Black, | ||
| FontSize = 16, | ||
| // This binding works with string items | ||
| BindingContext = "{Binding .}" | ||
| }; |
There was a problem hiding this comment.
Setting BindingContext to a string literal instead of using the SetBinding method. This should be SetBinding(Label.TextProperty, new Binding(".")) or use a proper binding syntax.
Suggested change
| return new Label | |
| { | |
| TextColor = Colors.Black, | |
| FontSize = 16, | |
| // This binding works with string items | |
| BindingContext = "{Binding .}" | |
| }; | |
| var label = new Label | |
| { | |
| TextColor = Colors.Black, | |
| FontSize = 16, | |
| }; | |
| label.SetBinding(Label.TextProperty, new Binding(".")); | |
| return label; |
PureWeen
added
the
p/0
jsuarezruiz
approved these changes
Oct 21, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
…d EmptyView not resized in CollectionView (#31916) * Update StructuredItemsViewController2.cs * fix updated * Test case added * Update StructuredItemsViewController2.cs * Update Issue31899.cs * Update Issue31899.cs * Test fail changes updated * Order value changed * Added snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
When the Header or Footer is set to null at runtime, empty space remains in the layout because their heights are still included while calculating the EmptyView frame.
Description of Change
Added cleanup logic for header and footer views in UpdateHeaderView and UpdateFooterView methods.
When the Header or Footer (or their templates) are set to null, the corresponding native views are now removed from the CollectionView using their assigned tags.
Issues Fixed
Fixes #31899
Tested the behavior in the following platforms.
Output Screenshot
Before.mov
After.mov