Skip to content

Conversation

@rmarinho
Copy link
Member

@rmarinho rmarinho commented Oct 7, 2025

Description of Change

API28 device tests are failing a lot, we have a lot of coverage with the other api levels so skipping this one

Copilot AI review requested due to automatic review settings October 7, 2025 17:24
@rmarinho rmarinho added area-testing Unit tests, device tests testing-flakiness labels Oct 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes API level 28 from Android device testing due to frequent test failures. Since other API levels provide adequate test coverage, removing the problematic API 28 tests improves pipeline reliability without significantly impacting test coverage.

  • Removes Android API 28 from the device test matrix

@rmarinho
Copy link
Member Author

rmarinho commented Oct 7, 2025

/backport to net10.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

@rmarinho backporting to "net10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: [testing] Don t test api28
Using index info to reconstruct a base tree...
M	eng/pipelines/device-tests.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/device-tests.yml
CONFLICT (content): Merge conflict in eng/pipelines/device-tests.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 [testing] Don t test api28
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@rmarinho rmarinho merged commit f3a11af into main Oct 8, 2025
121 of 129 checks passed
@rmarinho rmarinho deleted the dont-test-api28 branch October 8, 2025 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests testing-flakiness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants