fix10 #31459
Merged
fix10 #31459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates generated code in a source generator unit test to fix variable naming conflicts and improve null safety. The changes appear to be related to XAML service provider initialization in the .NET MAUI controls framework.
- Adds a new
iProvideValueTargetvariable at the beginning of the method - Renames subsequent
iProvideValueTargetvariables to avoid naming conflicts (iProvideValueTarget1,iProvideValueTarget2) - Updates array declarations from
object[]toobject?[]for null safety - Changes constructor parameter from
falsetothisinSimpleValueTargetProvidercalls
mattleibow
approved these changes
Sep 2, 2025
jsuarezruiz
approved these changes
Sep 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Issues Fixed
Fixes #