Skip to content

[iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix #31303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfversluis merged 1 commit into from
Aug 27, 2025
Merged

[iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix #31303

jfversluis merged 1 commit into from
Aug 27, 2025

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Aug 22, 2025 •
edited
Loading

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Moved the CollectionChanged event handler attachment for _tracker to the initialization logic, removing redundant event handler management from WillMoveToParentViewController. This simplifies event handling and ensures the handler is consistently attached.

Issues Fixed

Fixes #31278

@kubaflo
Attach CollectionChanged handler in NavigationRenderer
d09c577 
Moved the CollectionChanged event handler attachment for _tracker to the initialization logic, removing redundant event handler management from WillMoveToParentViewController. This simplifies event handling and ensures the handler is consistently attached.
Copilot AI review requested due to automatic review settings August 22, 2025 22:45
@kubaflo kubaflo requested a review from a team as a code owner August 22, 2025 22:45
@kubaflo kubaflo changed the base branch from main to net10.0 August 22, 2025 22:46
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 22, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 22, 2025

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo self-assigned this Aug 22, 2025
@kubaflo kubaflo changed the title Fix 31278 [iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix Aug 22, 2025
Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

PureWeen
PureWeen requested changes Aug 23, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a uitest code this one?

@kubaflo
Copy link
Contributor Author

kubaflo commented Aug 23, 2025

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Aug 27, 2025

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

Could try to use the SwipeRightToLeft with a small swipe percentage:

maui/src/TestUtils/src/UITest.Appium/HelperExtensions.cs

Line 1050 in 936db46

public static void SwipeRightToLeft(this IApp app, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)
?

@kubaflo
Copy link
Contributor Author

kubaflo commented Aug 27, 2025

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

Could try to use the SwipeRightToLeft with a small swipe percentage:

maui/src/TestUtils/src/UITest.Appium/HelperExtensions.cs

Line 1050 in 936db46

public static void SwipeRightToLeft(this IApp app, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)

?

It didn't work :/

@jfversluis jfversluis merged commit cf546bb into dotnet:net10.0 Aug 27, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@PureWeen PureWeen PureWeen requested changes

@jfversluis jfversluis jfversluis approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@kubaflo kubaflo

Labels

area-controls-toolbar ToolBar community ✨ Community Contribution platform/ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kubaflo @jsuarezruiz @jfversluis @PureWeen