[Android & iOS] Fix for SearchHandler Character Spacing Property by SubhikshaSf4851 · Pull Request #29497 · dotnet/maui

SubhikshaSf4851 · 2025-05-14T14:30:03Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause:

The CharacterSpacing property of the SearchHandler is not implemented on either iOS or Android.

Description of Change

The CharacterSpacing property for SearchHandler has been implemented on both iOS and Android.

Issues Fixed

Fixes #29492

Tested the behavior in the following platforms

Windows
Android
iOS
Mac

Screen Recording

iOS Before Issue Fix	iOS After Issue Fix
Screen.Recording.2025-05-14.at.6.40.40.PM.mov	Screen.Recording.2025-05-14.at.6.11.49.PM.mov

Android Before Issue Fix	Android After Issue Fix
Screen.Recording.2025-05-14.at.6.43.23.PM.mov	Screen.Recording.2025-05-14.at.6.08.56.PM.mov

dotnet-policy-service · 2025-05-14T14:30:25Z

Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR implements the missing CharacterSpacing property on SearchHandler for both iOS and Android, and adds a UI test to verify its behavior.

iOS and Android appearance trackers now listen for and apply CharacterSpacingProperty
A new HostApp page and Shared UI test (Issue29492) were added to drive and validate the spacing
Screenshots are used to confirm visual changes on mobile platforms

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs	Listens for `CharacterSpacingProperty` changes and applies them
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs	Invokes `UpdateCharacterSpacing` on setup and property changes
src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs	Defines a page with a `SearchHandler` and button to trigger query
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs	Adds a UITest that taps the search handler and captures a screenshot

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs:1

[nitpick] The macro and issue link reference issue 29493, but this test is for issue 29492. Rename or update the comment/link to avoid confusion.

#if TEST_FAILS_ON_WINDOWS  // Windows Character Spacing Issue Link - https://github.com/dotnet/maui/issues/29493

Copilot · 2025-05-15T08:17:19Z

+			var attributedText = textField.AttributedText?.WithCharacterSpacing(_searchHandler.CharacterSpacing);
+			if (attributedText is not null)
+			{
+				textField.AttributedText = attributedText;
+			}
+
+			var placeholderAttributedText = textField.AttributedPlaceholder?.WithCharacterSpacing(_searchHandler.CharacterSpacing);
+			if (placeholderAttributedText is not null)
+			{
+				textField.AttributedPlaceholder = placeholderAttributedText;
+			}


If AttributedText is null, no character spacing will be applied. Consider creating a new attributed string from textField.Text and applying the spacing so it always takes effect.

Suggested change

var attributedText = textField.AttributedText?.WithCharacterSpacing(_searchHandler.CharacterSpacing);

if (attributedText is not null)

{

textField.AttributedText = attributedText;

}

var placeholderAttributedText = textField.AttributedPlaceholder?.WithCharacterSpacing(_searchHandler.CharacterSpacing);

if (placeholderAttributedText is not null)

{

textField.AttributedPlaceholder = placeholderAttributedText;

}

var attributedText = textField.AttributedText?.WithCharacterSpacing(_searchHandler.CharacterSpacing)

?? new NSAttributedString(textField.Text ?? string.Empty, new UIStringAttributes { KerningAdjustment = (float)_searchHandler.CharacterSpacing });

textField.AttributedText = attributedText;

var placeholderAttributedText = textField.AttributedPlaceholder?.WithCharacterSpacing(_searchHandler.CharacterSpacing)

?? new NSAttributedString(textField.Placeholder ?? string.Empty, new UIStringAttributes { KerningAdjustment = (float)_searchHandler.CharacterSpacing });

textField.AttributedPlaceholder = placeholderAttributedText;

jsuarezruiz · 2025-05-16T11:24:35Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-16T11:24:47Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-20T09:01:35Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-20T09:01:48Z

Azure Pipelines successfully started running 1 pipeline(s).

) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <[email protected]> Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Dhivya-SF4094 <[email protected]> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <[email protected]> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Tamilarasan Paranthaman <[email protected]> Co-authored-by: NafeelaNazhir <[email protected]> Co-authored-by: Paul Anderson <[email protected]> Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Dhivya-SF4094 <[email protected]> Co-authored-by: devanathan-vaithiyanathan <[email protected]> Co-authored-by: Subhiksha Chandrasekaran <[email protected]> Co-authored-by: BagavathiPerumal <[email protected]> Co-authored-by: prakashKannanSf3972 <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: SuthiYuvaraj <[email protected]> Co-authored-by: SyedAbdulAzeemSF4852 <[email protected]> Co-authored-by: Anandhan Rajagopal <[email protected]> Co-authored-by: Bhavanesh N <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>

…rty (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs

… property does not update text in the search box (#28400)" (#30250) * Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" This reverts commit 559da79. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs * Revert "[Android & iOS] Fix for SearchHandler Character Spacing Property (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs * - remove character spacing

…ty does not update text in the search box (#28400)" (#30222) * Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" This reverts commit 559da79. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs * Revert "[Android & iOS] Fix for SearchHandler Character Spacing Property (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs * - remove character spacing

SubhikshaSf4851 added 3 commits May 14, 2025 18:27

[Android & iOS] Fix for character spacing in searchHandler

e63af80

Updated test sample concerns

a932878

Update on naming

adee7de

dotnet-policy-service Bot added the community ✨ Community Contribution label May 14, 2025

dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label May 14, 2025

SubhikshaSf4851 added 2 commits May 15, 2025 12:06

Update on formatting

fe3020c

Allowing updating character spacing to zero

7445470

SubhikshaSf4851 marked this pull request as ready for review May 15, 2025 08:16

Copilot AI review requested due to automatic review settings May 15, 2025 08:16

SubhikshaSf4851 requested a review from a team as a code owner May 15, 2025 08:16

SubhikshaSf4851 requested review from jfversluis and jsuarezruiz May 15, 2025 08:16

Copilot AI reviewed May 15, 2025

View reviewed changes

jsuarezruiz reviewed May 19, 2025

View reviewed changes

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs

Updated Andorid, iOS, Mac images

2feb525

jsuarezruiz approved these changes May 26, 2025

View reviewed changes

rmarinho approved these changes May 28, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 28, 2025 18:31

rmarinho merged commit 22a864d into dotnet:inflight/current May 28, 2025

PureWeen mentioned this pull request Jun 25, 2025

Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" #30222

Merged

github-actions Bot locked and limited conversation to collaborators Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android & iOS] Fix for SearchHandler Character Spacing Property#29497

[Android & iOS] Fix for SearchHandler Character Spacing Property#29497
rmarinho merged 6 commits into
dotnet:inflight/currentfrom
SubhikshaSf4851:fix-29492

SubhikshaSf4851 commented May 14, 2025

Uh oh!

dotnet-policy-service Bot commented May 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 15, 2025

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines Bot commented May 16, 2025

Uh oh!

Uh oh!

jsuarezruiz commented May 20, 2025

Uh oh!

azure-pipelines Bot commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

SubhikshaSf4851 commented May 14, 2025

Root Cause:

Description of Change

Issues Fixed

Tested the behavior in the following platforms

Screen Recording

Uh oh!

dotnet-policy-service Bot commented May 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 15, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines Bot commented May 16, 2025

Uh oh!

Uh oh!

jsuarezruiz commented May 20, 2025

Uh oh!

azure-pipelines Bot commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants