[MacOS] Picker's dialog improvement #27525
Merged
+55
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
reviewed
Feb 2, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
kubaflo
force-pushed
the
When-opening-the-Picker,-the-first-item-is-selected-instead-of-the-currently-selected-item
branch
from
3cbf163 to
c28f19f
Compare
mattleibow
reviewed
Feb 4, 2025
| pickerView?.ReloadAllComponents(); | ||
| var source = (PickerSource)pickerView.Model; | ||
| source.SelectedIndex = selectedIndex; | ||
| pickerView.Select(Math.Max(selectedIndex, 0), 0, true); |
Member
There was a problem hiding this comment.
Should this be a clamp with the min max? What happens if the selected index is larger than the number of items? Can it be larger?
| bool OnShouldBeginEditing (UITextField textField) | ||
| bool OnShouldBeginEditing(UITextField textField) | ||
| { | ||
| if (Handler is not PickerHandler handler) |
Member
There was a problem hiding this comment.
Mayne just bail out if virtual view is null like the end editing instead of the null check but still shopping the popup.
kubaflo
force-pushed
the
When-opening-the-Picker,-the-first-item-is-selected-instead-of-the-currently-selected-item
branch
from
c28f19f to
b5c831a
Compare
Member
|
/rebase |
github-actions
bot
force-pushed
the
When-opening-the-Picker,-the-first-item-is-selected-instead-of-the-currently-selected-item
branch
from
b5c831a to
eb74096
Compare
jfversluis
approved these changes
Aug 12, 2025
jfversluis
force-pushed
the
When-opening-the-Picker,-the-first-item-is-selected-instead-of-the-currently-selected-item
branch
from
eb74096 to
8f3e1e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #27519
Fixes #29633
Screen.Recording.2025-02-02.at.17.31.28.mov
Screen.Recording.2025-02-02.at.17.27.28.mov