[Android] PopToRootAsync for modal pages - improvements by kubaflo · Pull Request #26851 · dotnet/maui

kubaflo · 2024-12-27T23:49:12Z

Issues Fixed

Before	After
Screen.Recording.2024-12-27.at.20.46.44.mov	Screen.Recording.2024-12-27.at.20.45.08.mov

kubaflo · 2024-12-27T23:57:19Z

Hi @pictos what do you think about this?

gabsamples6 · 2024-12-31T07:09:08Z

We are affected by this as well any estimate when this will be merged ? thanks

Zack-G-I-T · 2025-01-03T12:28:18Z

Hi, this pull request looks promising! Is there any update on when this will get reviewed?

kubaflo · 2025-01-03T12:48:51Z

Hi @Zack-G-I-T probably next week :)

gabsamples6 · 2025-01-07T07:31:32Z

@kubaflo hi is there any chance of this making next release? thanks a lot!

kubaflo · 2025-01-07T08:56:36Z

Hi @gabsamples6 it is not up to me. However, I think that there's a chance. cheers!

gabsamples6 · 2025-01-08T07:50:17Z

@rmarinho @PureWeen Very grateful if this could be merged in readiness for next release,is holding us up on few screens on our app.

PureWeen

This implementation causes pages to just be popped FIFO instead of LIFO

I created a basic sample that just pops modal pages and you'll notice that as you pop modal pages only the first one gets popped not the currently visible on.

Can you add a unit test that would have caught this?

public MainPage()
	{
		InitializeComponent();
		asdf.Clicked +=	async (s, e) =>
		{
			var button = (s as IView);
			await Navigation.PushModalAsync(new NavigationPage(new MainPage(){ Title = $"Modal Page: {_count++}" }));
		};

		asdf2.Clicked += async (s, e) =>
		{
			await Navigation.PopModalAsync(false);
		};
	}

kubaflo · 2025-02-01T15:57:54Z

asdf.Clicked +=	async (s, e) =>
		{
			var button = (s as IView);
			await Navigation.PushModalAsync(new NavigationPage(new MainPage(){ Title = $"Modal Page: {_count++}" }));
		};

		asdf2.Clicked += async (s, e) =>
		{
			await Navigation.PopModalAsync(false);
		};

Hmm, I'm not sure I understand your case

I've created this sample

Content = new VerticalStackLayout
{
	Children = {
		new Label { Text = "This is a modal page1" },
		new Button { Text = "Open modal page2", Command = new Command(async () => await Navigation.PushModalAsync(new ContentPage()
			{
				Content = new VerticalStackLayout
				{
					Children = {
						new Label { Text = "This is a modal page2" },
						new Button { Text = "Open modal page3", Command = new Command(async () => await Navigation.PushModalAsync(new ContentPage()
						{
							Content = new VerticalStackLayout
							{
								Children = {
									new Label { Text = "This is a modal page3" },
									new Button { Text = "Close", Command = new Command(async () => await Navigation.PopModalAsync()) }
								}
							}
						})) },
						new Button { Text = "Close", Command = new Command(async () => await Navigation.PopModalAsync()) }
					}
				}
			})) },
		new Button { Text = "Close", Command = new Command(async () => await Navigation.PopModalAsync()) }
	}
}

And it appears to be working fine

Screen.Recording.2025-02-01.at.16.55.12.mov

PureWeen · 2025-02-03T22:00:33Z

@kubaflo I'm sorry, I did a really poor job giving you all the details here.

I've pushed up a commit with your sample modified slightly to demonstrate what I was talking about

PureWeen · 2025-02-06T18:51:31Z

@kubaflo I'm sorry, I did a really poor job giving you all the details here.

I've pushed up a commit with your sample modified slightly to demonstrate what I was talking about

Can you add a UI test that would have caught this?

kubaflo · 2025-02-07T16:38:46Z

@PureWeen I've added a test :)

Revert changes to ModalNavigationManager.cs (shared), ModalNavigationManager.iOS.cs, and ShellSection.cs. Instead of changing pop order (FIFO) and using DismissNow() for ALL non-animated pops, scope DismissNow() to only batch-dismiss scenarios by checking the existing IsPoppingModalStack flag on ShellSection. This fixes the gate failure where ModalPoppingShouldWorkOneByOne broke because DismissNow() was applied too broadly to single modal pops. The scoped approach: - Uses existing IsPoppingModalStack flag (no new IsPoppingModalStackToRoot needed) - Only applies DismissNow() during PopToRoot batch pops - Keeps correct LIFO pop order (no Stack->List conversion needed) - Changes only 1 implementation file (~10 lines) Co-authored-by: Copilot <[email protected]>

kubaflo · 2026-03-27T16:37:19Z

Applied the recommended fix from the AI review (Attempt 1 / claude-opus-4.6):

Changes in ae57dd5d4c:

Reverted broad changes to ModalNavigationManager.cs (shared), ModalNavigationManager.iOS.cs, and ShellSection.cs
Replaced the global Dismiss() to DismissNow() change with a scoped DismissNow() that only activates during batch modal pops (via existing IsPoppingModalStack flag)
Reverted Stack<string> to List<string> conversion (LIFO order preserved)
Removed the IsPoppingModalStackToRoot flag (uses existing IsPoppingModalStack instead)

Why this is better than the previous approach:

DismissNow() is scoped to batch pops only, preserving original Dismiss() for single modal pops (fixes the gate failure on ModalPoppingShouldWorkOneByOne)
Only 1 implementation file changed (~10 lines) vs 4 files previously
Null-safe access: shell.CurrentItem?.CurrentItem?.IsPoppingModalStack
Test files (Issue26846.cs) kept as-is

kubaflo · 2026-04-01T14:33:24Z

Code Review — PR #26851

Independent Assessment

What this changes: In Android's PopModalPlatformAsync, when batch-dismissing modals (e.g., PopToRootAsync in Shell), uses DialogFragment.DismissNow() (synchronous) instead of Dismiss() (asynchronous) for intermediate modal pages. This prevents intermediate modals from briefly flashing on screen between sequential pops.

How it detects batch popping: Reuses the existing ShellSection.IsPoppingModalStack flag, which is already set true during batch pop loops and set false before the last modal pop. This means:

Intermediate modals → DismissNow() (sync, no flash) ✅
Last modal in batch → Dismiss() (async, can animate) ✅
Non-batch pops → Dismiss() (unchanged behavior) ✅
Non-Shell apps → Dismiss() (unchanged behavior) ✅

Inferred motivation: Dismiss() posts the fragment removal to the message queue. During rapid sequential pops, the message queue hasn't processed the previous removal yet, so the previous modal briefly becomes visible before it's dismissed.

Reconciliation with PR Narrative

Author claims: Fixes #26846 — Shell PopToRootAsync causes previous pages to flash.
Agreement: Matches my assessment. The current code is the scoped fix (commit ae57dd5) that replaced an earlier broader approach which PureWeen correctly flagged as breaking LIFO pop order. The current version maintains LIFO order via _modals.Pop() and only changes the dismiss timing.

Previous reviewer feedback:

PureWeen (CHANGES_REQUESTED): Flagged FIFO pop order in an earlier version. The current code does not have this issue — LIFO order is maintained. The test ModalPoppingShouldWorkOneByOne was added to catch this.
rmarinho (CHANGES_REQUESTED): Noted animated PopToRoot only animates the top page, not intermediate ones. This appears to be pre-existing behavior unrelated to the current diff.

Findings

⚠️ PR title says "[Android & iOS]" but diff only touches Android

The PR title mentions iOS but the current diff has no iOS changes (the earlier iOS changes were reverted per the agent fix). The title should be updated to [Android] to match the actual scope.

⚠️ Missing newline at end of test file

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26846.cs is missing a trailing newline.

💡 HostApp deeply nested lambdas

The Issue26846.cs HostApp page uses deeply nested inline lambda constructors (3 levels of modal pages). While functional, this is harder to read than extracting each page into a method or local function. Not a blocker.

Devil's Advocate

"Could DismissNow() throw after onSaveInstanceState?" — Batch modal popping is triggered by UI interaction, so it won't happen after state save. Negligible risk.
"Does synchronous OnDismiss cause issues?" — modal is captured as a local variable before dismiss, so source.TrySetResult(modal) correctly resolves.
"Is IsPoppingModalStack reliable?" — Yes, already used by cross-platform PopModalAsync (line 226) to suppress appearing events. Has try/finally cleanup.

Verdict: LGTM

Confidence: high
Summary: The scoped fix is minimal, correct, and well-targeted. It reuses the existing IsPoppingModalStack flag to distinguish batch from single modal pops, and only changes the dismiss timing for intermediate modals. LIFO order is maintained, non-Shell and non-batch scenarios are unaffected. CI is green. The outstanding CHANGES_REQUESTED reviews appear to be about previous iterations. Title mismatch with scope is the only notable issue.

kubaflo · 2026-04-01T15:33:44Z

🟢 .NET MAUI Review - Approved

Expand Full Review - ae57dd5 - [Android & iOS] PopToRootAsync for modal pages - improvements

Independent Assessment

What this changes: In Android's PopModalPlatformAsync, when batch-dismissing modals (e.g., PopToRootAsync in Shell), uses DialogFragment.DismissNow() (synchronous) instead of Dismiss() (asynchronous) for intermediate modal pages. This prevents intermediate modals from briefly flashing on screen between sequential pops.

How it detects batch popping: Reuses the existing ShellSection.IsPoppingModalStack flag, which is already set true during batch pop loops and set false before the last modal pop. This means:

Intermediate modals → DismissNow() (sync, no flash) ✅
Last modal in batch → Dismiss() (async, can animate) ✅
Non-batch pops → Dismiss() (unchanged behavior) ✅
Non-Shell apps → Dismiss() (unchanged behavior) ✅

Inferred motivation: Dismiss() posts the fragment removal to the message queue. During rapid sequential pops, the message queue hasn't processed the previous removal yet, so the previous modal briefly becomes visible before it's dismissed.

Reconciliation with PR Narrative

Author claims: Fixes #26846 — Shell PopToRootAsync causes previous pages to flash.
Agreement: Matches my assessment. The current code is the scoped fix (commit ae57dd5) that replaced an earlier broader approach which PureWeen correctly flagged as breaking LIFO pop order. The current version maintains LIFO order via _modals.Pop() and only changes the dismiss timing.

Previous reviewer feedback:

PureWeen (CHANGES_REQUESTED): Flagged FIFO pop order in an earlier version. The current code does not have this issue — LIFO order is maintained. The test ModalPoppingShouldWorkOneByOne was added to catch this.
rmarinho (CHANGES_REQUESTED): Noted animated PopToRoot only animates the top page, not intermediate ones. This appears to be pre-existing behavior unrelated to the current diff.

Findings

⚠️ PR title says "[Android & iOS]" but diff only touches Android

The PR title mentions iOS but the current diff has no iOS changes (the earlier iOS changes were reverted per the agent fix). The title should be updated to [Android] to match the actual scope.

⚠️ Missing newline at end of test file

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26846.cs is missing a trailing newline.

💡 HostApp deeply nested lambdas

The Issue26846.cs HostApp page uses deeply nested inline lambda constructors (3 levels of modal pages). While functional, this is harder to read than extracting each page into a method or local function. Not a blocker.

Devil's Advocate

"Could DismissNow() throw after onSaveInstanceState?" — Batch modal popping is triggered by UI interaction, so it won't happen after state save. Negligible risk.
"Does synchronous OnDismiss cause issues?" — modal is captured as a local variable before dismiss, so source.TrySetResult(modal) correctly resolves.
"Is IsPoppingModalStack reliable?" — Yes, already used by cross-platform PopModalAsync (line 226) to suppress appearing events. Has try/finally cleanup.

Verdict

Verdict: LGTM
Confidence: high
Summary: The scoped fix is minimal, correct, and well-targeted. It reuses the existing IsPoppingModalStack flag to distinguish batch from single modal pops, and only changes the dismiss timing for intermediate modals. LIFO order is maintained, non-Shell and non-batch scenarios are unaffected. CI is green. The outstanding CHANGES_REQUESTED reviews appear to be about previous iterations. Title mismatch with scope is the only notable issue.

github-actions · 2026-04-01T15:54:51Z

🔍 Prior Fix Regression Check

Result: ✅ No prior fix regressions detected

Checked deleted lines across implementation files. No lines were identified as reversions of prior bug fixes.

👍 / 👎 — Was this check helpful? React to let us know!

🔍 Regression check by Prior Fix Regression Check

### Issues Fixed Fixes #26846 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/4be00a9f-200b-4d84-9826-51b464a89e24" width="300px"/>|<video src="https://github.com/user-attachments/assets/831e2554-4739-42b6-8758-cc49b6ee5449" width="300px"/>| --------- Co-authored-by: Copilot <[email protected]>

### Issues Fixed Fixes dotnet#26846 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/4be00a9f-200b-4d84-9826-51b464a89e24" width="300px"/>|<video src="https://github.com/user-attachments/assets/831e2554-4739-42b6-8758-cc49b6ee5449" width="300px"/>| --------- Co-authored-by: Copilot <[email protected]>

### Issues Fixed Fixes #26846 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/4be00a9f-200b-4d84-9826-51b464a89e24" width="300px"/>|<video src="https://github.com/user-attachments/assets/831e2554-4739-42b6-8758-cc49b6ee5449" width="300px"/>| --------- Co-authored-by: Copilot <[email protected]>

### Issues Fixed Fixes dotnet#26846 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/4be00a9f-200b-4d84-9826-51b464a89e24" width="300px"/>|<video src="https://github.com/user-attachments/assets/831e2554-4739-42b6-8758-cc49b6ee5449" width="300px"/>| --------- Co-authored-by: Copilot <[email protected]>

### Issues Fixed Fixes #26846 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/4be00a9f-200b-4d84-9826-51b464a89e24" width="300px"/>|<video src="https://github.com/user-attachments/assets/831e2554-4739-42b6-8758-cc49b6ee5449" width="300px"/>| --------- Co-authored-by: Copilot <[email protected]>

@mattleibow

## Blazor - Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by @mattleibow in #33917 <details> <summary>🔧 Fixes</summary> - [.NET MAUI Blazor Hybrid App should not precompress assets](#33773) </details> - [Windows] Fix for Runtime error when closing external window with WPF Webview Control by @BagavathiPerumal in #34006 <details> <summary>🔧 Fixes</summary> - [Runtime error when closing external window with WPF Webview Control](#32944) </details> ## Button - [Android] ImageButton CornerRadius not being applied - fix by @kubaflo in #30074 <details> <summary>🔧 Fixes</summary> - [ImageButton CornerRadius not being applied on Android](#23854) </details> - Fix Disabled visual state ignored when Button has locally-set BackgroundColor/TextColor by @Dhivya-SF4094 in #34444 <details> <summary>🔧 Fixes</summary> - [[regression/9.0] VisualState "Disabled" is not properly applied for Button with custom appearance](#34363) </details> ## CollectionView - Fix CollectionView grid spacing updates for first row and column by @KarthikRajaKalaimani in #34527 <details> <summary>🔧 Fixes</summary> - [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item Spacing - horizontally updating the spacing only applies to the second column](#34257) </details> - Fix CollectionView record struct selection on Windows by @jeremy-visionaid in #33488 - [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the items source by @filipnavara in #24610 <details> <summary>🔧 Fixes</summary> - [Crash on NullReferenceException with measurement cells in CollectionView](#24304) </details> - [Windows] Fixed VisualState Setters not working properly for CollectionView by @Dhivya-SF4094 in #27230 <details> <summary>🔧 Fixes</summary> - [VisualState Setters not working properly on Windows for a CollectionView](#27086) - [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set Style in ContentPage.Resources](#19209) - [[Windows] Label style defined as ContentPage Resource doesn't propagate to CollectionView](#18701) </details> - [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by @Dhivya-SF4094 in #29897 <details> <summary>🔧 Fixes</summary> - [Margin doesn't work inside CollectionView EmptyView](#8494) </details> - [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem incorrect during animated ScrollTo() by @praveenkumarkarunanithi in #34570 <details> <summary>🔧 Fixes</summary> - [[Android] CurrentItemChangedEventArgs.PreviousItem and PositionChangedEventArgs.PreviousPosition Not Updating Correctly When Using ScrollTo or Setting Position](#29544) </details> - [iOS] CarouselView2: Update internal scroll indicators for compositional layout by @SubhikshaSf4851 in #33639 <details> <summary>🔧 Fixes</summary> - [[iOS] Horizontal Scroll Bar Not Visible on CarouselView (CV2)](#29390) </details> - [CarouselViewHandler2] Fir fox CurrentItem does not work when ItemSpacing is set by @SyedAbdulAzeemSF4852 in #32135 <details> <summary>🔧 Fixes</summary> - [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is set](#32048) </details> - [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not Found in ItemsSource by @SyedAbdulAzeemSF4852 in #32141 <details> <summary>🔧 Fixes</summary> - [[Android & iOS] Setting an invalid CurrentItem causes scroll to last item in looped CarouselView](#32139) </details> - [Android] IndicatorView: Add TalkBack accessibility descriptions for indicators by @praveenkumarkarunanithi in #31775 <details> <summary>🔧 Fixes</summary> - [[Android] IndicatorView does not convey correct accessibility information](#31446) </details> - [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically by @NanthiniMahalingam in #32191 <details> <summary>🔧 Fixes</summary> - [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep the last item at the end of the displayed list when adding new items.](#31825) </details> - [Windows, Android] Resolved issue with dynamic Header/Footer reassignment in CollectionView. by @prakashKannanSf3972 in #28403 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] Toggling Header/Footer in CollectionView Dynamically is not working](#27959) - [CollectionView HeaderTemplate and FooterTemplate are not displayed when ItemsSource is initially set to null](#28337) - [[Android] Header and Footer Not Visible in CollectionView When EmptyView is Selected First](#28351) </details> - [Android] Fix CollectionView inside disabled RefreshView blocks scroll by @Vignesh-SF3580 in #34702 <details> <summary>🔧 Fixes</summary> - [C6-The C6 page cannot scroll on Windows and Android platforms.](#34666) </details> - [Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item by @KarthikRajaKalaimani in #31591 <details> <summary>🔧 Fixes</summary> - [CollectionView - SelectedItem visual state manager not working](#20062) </details> - [Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null by @Dhivya-SF4094 in #29487 <details> <summary>🔧 Fixes</summary> - [[Windows] CollectionView.EmptyView can not be removed by setting it to Null](#18657) - [[Windows] EmptyViewTemplate Not Working in CarouselView](#29463) - [EmptyViewTemplate does not do anything](#18551) - [[MAUI] I5_EmptyView - The data template selector cannot display the correct string.](#23330) </details> - [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in #29996 <details> <summary>🔧 Fixes</summary> - [[iOS] IsSwipeEnabled Not Working on CarouselView (CV2)](#29391) </details> - [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in CollectionView by @Dhivya-SF4094 in #32775 <details> <summary>🔧 Fixes</summary> - [[iOS, MacOS] FlowDirection not working on Header/Footer in CollectionView](#32771) </details> - [iOS] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #34151 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [Android] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #31867 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by @Vignesh-SF3580 in #34700 <details> <summary>🔧 Fixes</summary> - [CarouselView vertical snap points ignored on iOS with Microsoft.Maui.Controls v10.0.20 (regression from v9.0.120)](#33308) </details> - [iOS26] Fix CarouselView scrolling to wrong item when navigating to last item by @Vignesh-SF3580 in #34013 <details> <summary>🔧 Fixes</summary> - [[iOS 26] CarouselView does not scroll to the correct last item](#33770) </details> - Fixed the OnPlatform does not work for header property in Collection view by @NanthiniMahalingam in #28935 <details> <summary>🔧 Fixes</summary> - [OnPlatform does not work in Header of CollectionView](#25124) </details> - [Android] [Candidate branch] Fix VerifySelectedItemClearsOnNullAssignment, CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test failure on Android by @KarthikRajaKalaimani in #34928 ## DateTimePicker - [iOS] Fix for DatePicker FlowDirection Not Working on iOS by @SyedAbdulAzeemSF4852 in #30193 <details> <summary>🔧 Fixes</summary> - [[iOS] DatePicker FlowDirection Not Working on iOS](#30065) </details> ## Drawing - [Shapes] Line: Fix asymmetric Stretch.None path translation when right/bottom edge overflows by @NirmalKumarYuvaraj in #34385 <details> <summary>🔧 Fixes</summary> - [Line coordinates not computed correctly](#11404) - [Lines not drawing correctly](#26961) </details> - [Android] Fixed GraphicsView drawable is visible outside the canvas by @NirmalKumarYuvaraj in #28353 <details> <summary>🔧 Fixes</summary> - [[Android] GraphicsView， The drawn image can also be visible outside the canvas](#20834) </details> - Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj in #29442 <details> <summary>🔧 Fixes</summary> - [Custom IDrawable control does not databind to a model property when used inside a CollectionView ItemTemplate](#20991) </details> - Added a support for GradientBrushes on Shape.Stroke by @kubaflo in #22208 <details> <summary>🔧 Fixes</summary> - [GradientBrushes are not supported on Shape.Stroke](#21983) </details> ## Editor - Fixed Editor HorizontalTextAlignment does not update at run time by @NirmalKumarYuvaraj in #25129 <details> <summary>🔧 Fixes</summary> - [Editor HorizontalTextAlignment Does not Works.](#10987) - [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor placeholder](#30052) </details> - [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by @SubhikshaSf4851 in #30324 <details> <summary>🔧 Fixes</summary> - [[Windows] CharacterSpacing not applied to Placeholder text in Entry and Editor controls](#30071) </details> ## Entry - [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be interpreted as a password input by @SyedAbdulAzeemSF4852 in #29344 <details> <summary>🔧 Fixes</summary> - [[Windows] Entry Keyboad-Type "Date" results in Password-Entry](#28975) </details> - [Android] Exception thrown when give more than 5000 characters to the Text property of Entry. by @KarthikRajaKalaimani in #30242 <details> <summary>🔧 Fixes</summary> - [Android crash when Entry has >5000 characters](#30144) </details> ## Essentials - Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship Essentials.AI public APIs by @mattleibow via @Copilot in #34574 - [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by @HarishwaranVijayakumar in #32708 <details> <summary>🔧 Fixes</summary> - [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac OS](#26059) </details> ## Flyoutpage - [Windows] FlyoutPage: update CollapseStyle at runtime by @devanathan-vaithiyanathan in #29927 <details> <summary>🔧 Fixes</summary> - [Flyout Page SetCollapseStyle doesn't have any change](#18200) </details> ## Gestures - [Android] Fix for TapGestureRecognizer doesn't fire by @HarishwaranVijayakumar in #34497 <details> <summary>🔧 Fixes</summary> - [[Android] TapGestureRecognizer doesn't fire](#5825) </details> ## Image - [Android] Fix Share.RequestAsync SecurityException on Android 10+ caused by missing ClipData by @HarishwaranVijayakumar in #34417 <details> <summary>🔧 Fixes</summary> - [[Bug] Share.RequestAsync throws java.lang.SecurityException (uid=1000) on Android 10+ due to missing intent.ClipData](#34370) </details> - [Windows]Fixed the MauiImage with logical name containing path issue by @sheiksyedm in #32864 <details> <summary>🔧 Fixes</summary> - [MauiImage with LogicalName containing path - is not working on Windows](#32356) </details> - [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in #30808 <details> <summary>🔧 Fixes</summary> - [[Android & Windows] In GraphicsView, the aspect ratio is not maintained when Downsize is called with both maxWidth and maxHeight](#30803) </details> ## Label - [iOS , macOS] Fixed Label text cropping when a width request is specified on the label inside a VerticalStackLayout with specified width request by @NanthiniMahalingam in #29166 <details> <summary>🔧 Fixes</summary> - [Label text gets cropped when a width request is specified on the label inside a VerticalStackLayout](#28660) - [[iOS] Label with a fixed WidthRequest has wrong height](#26644) </details> - [Android] Fix Label word wrapping clips text depending on alignment and layout options by @Dhivya-SF4094 in #34533 <details> <summary>🔧 Fixes</summary> - [Bug: Android Label word wrapping clips text depending on alignment and layout options](#34459) </details> - LineHeight and decorations for HTML Label - fix by @kubaflo in #31202 <details> <summary>🔧 Fixes</summary> - [LineHeight with HTML Label not working](#22193) - [lineheight is broken ](#22197) </details> - [iOS] Fix Label with TailTruncation not rendering after empty-to-non-empty text transition by @kubaflo in #34812 <details> <summary>🔧 Fixes</summary> - [Label with LineBreakMode="TailTruncation" does not render text if initial Text is null or empty on first render (iOS)](#34591) </details> ## Layout - [Android] Fix overflowing children clipped when parent Opacity < 1 by @SyedAbdulAzeemSF4852 in #34565 <details> <summary>🔧 Fixes</summary> - [Maui Android parent view inappropriately creates clipping mask when its opacity is less than 1, cropping out children](#22038) </details> - Fixed the FlexLayout reverse issue with the AlignContent by @Ahamed-Ali in #32134 <details> <summary>🔧 Fixes</summary> - [FlexLayout alignment issue when Wrap is set to Reverse and AlignContent is set to SpaceAround, SpaceBetween or SpaceEvenly](#31565) </details> - [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its default AutoSize for Height and Width after reset by @Dhivya-SF4094 in #31648 <details> <summary>🔧 Fixes</summary> - [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default AutoSize for Height/Width after reset](#31496) </details> ## Map - [Windows] Implement WinUI 3 MapControl handler using Azure Maps by @jfversluis in #34138 ## Modal - [Android] PopToRootAsync for modal pages - improvements by @kubaflo in #26851 <details> <summary>🔧 Fixes</summary> - [Shell PopToRootAsync doesn't happen instantly - previous pages flash quickly. Only happens in NET 9](#26846) </details> - [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by @HarishwaranVijayakumar in #34770 <details> <summary>🔧 Fixes</summary> - [HideSoftInputOnTapped doesn't work on Modal Pages](#34730) </details> ## Navigation - [iOS] Alert popup may be displayed on wrong window when modal page navigation is in progress - fix by @kubaflo in #31016 <details> <summary>🔧 Fixes</summary> - [Alert popup may be displayed on wrong window when modal page navigation is in progress on iOS/MacOS](#30970) </details> - [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is FlyoutPage Detail by @KarthikRajaKalaimani in #31931 <details> <summary>🔧 Fixes</summary> - [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is called twice](#23902) </details> ## Picker - Fixed the Picker didn't dismiss it when tapping outside on iOS and MacCatalyst platform. by @KarthikRajaKalaimani in #30067 <details> <summary>🔧 Fixes</summary> - [[regression/8.0.3] iOS Picker dismiss does not work when clicking outside of the Picker](#19168) </details> - [Windows] Fixed Picker items width wont resize back by @SubhikshaSf4851 in #33042 <details> <summary>🔧 Fixes</summary> - [Picker items width won't resize back when its container window gets resized down.](#32984) </details> ## RadioButton - Fix TalkBack not correctly narrating RadioButtons with Content by @SubhikshaSf4851 in #34521 <details> <summary>🔧 Fixes</summary> - [[Android] TalkBack does not correctly narrate RadioButtons with Content](#34322) </details> ## SafeArea - [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36 by @praveenkumarkarunanithi in #34239 ## ScrollView - [iOS] Preserve ScrollView offsets when Orientation changes to Neither by @Vignesh-SF3580 in #34672 <details> <summary>🔧 Fixes</summary> - [Incorrect implementation of ScrollView.Orientation](#34583) </details> ## Searchbar - [Android] Fix SearchBar text bleeding between instances after navigation by @SyedAbdulAzeemSF4852 in #34703 <details> <summary>🔧 Fixes</summary> - [MAUI Android: SearchBar copies content from one to the other](#20348) </details> - Fixed SearchBar CursorPosition and SelectionLength not updating when typing by @Dhivya-SF4094 in #34347 <details> <summary>🔧 Fixes</summary> - [SearchBar - CursorPosition and SelectionLength are not updated when the user types](#30779) </details> ## SearchBar - [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in #29520 <details> <summary>🔧 Fixes</summary> - [[Windows] SearchHandler APIs are not functioning properly](#29493) </details> ## Shell - [iOS, Mac] Fix for Background set to Transparent doesn't have the same behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in #32245 <details> <summary>🔧 Fixes</summary> - [Background set to Transparent doesn't have the same behavior as BackgroundColor = Transparent](#22769) </details> - [iOS] Fix App crash with NullReferenceException in ShellSectionRenderer by @devanathan-vaithiyanathan in #32109 <details> <summary>🔧 Fixes</summary> - [[iOS] App crash with NullReferenceException in ShellSectionRenderer](#31961) </details> - [Android] Fixed back button icon selection logic in ShellToolbarTracker by @kubaflo in #32080 <details> <summary>🔧 Fixes</summary> - [IconOverride in Shell.BackButtonBehavior does not work.](#32050) </details> - Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent by @Vignesh-SF3580 in #33090 <details> <summary>🔧 Fixes</summary> - [Shell.TabBarIsVisible is not updated dynamically at runtime](#32994) </details> - [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position by @NanthiniMahalingam in #32701 <details> <summary>🔧 Fixes</summary> - [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)](#32419) </details> - [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo in #28713 <details> <summary>🔧 Fixes</summary> - [[IOS, Mac] Inconsistent Resize Behavior for Header/Footer](#26397) - [Enable Shell Flyout Header/Footer resize tests on iOS/Catalyst](#33501) </details> - [Android] Fix for SearchHandler retaining previous page SearchView data in pages within Shell sections by @BagavathiPerumal in #29545 <details> <summary>🔧 Fixes</summary> - [[Shell][Android] The truth is out there...but not on top tab search handlers](#8716) </details> - [Android] Fix empty space above TabBar after navigating back when TabBar visibility is toggled by @praveenkumarkarunanithi in #34324 <details> <summary>🔧 Fixes</summary> - [Empty space appears above TabBar after navigating back when TabBar visibility is toggled](#33703) - [Grid with SafeAreaEdges=Container has incorrect size when tab bar appears](#34256) </details> ## SwipeView - [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout to fix text visibility by @Ahamed-Ali in #27399 <details> <summary>🔧 Fixes</summary> - [[Android] Right SwipeView items are not visible in the SwipeView.](#27367) </details> - [Android] Prevent the tap that closes an open SwipeView from being propagated to children by @sjordanGSS in #24275 <details> <summary>🔧 Fixes</summary> - [Tapping to close a SwipeView will activate TapGestureRecognizers on .Content](#23921) </details> ## Switch - [iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs by @BagavathiPerumal in #34735 <details> <summary>🔧 Fixes</summary> - [[Shell] [iOS & Mac] SearchHandler retains previous page state when switching top tabs](#34693) </details> ## TabbedPage - [Android] Fixed NullReferenceException in app with TabBar after returning from minimized state by @NirmalKumarYuvaraj in #34779 <details> <summary>🔧 Fixes</summary> - [NullReferenceException in app with TabBar after returning from minimized state](#34720) </details> ## Titlebar - Fixed BindingContext of the Window TitleBar is not being passed on to its child content. by @NirmalKumarYuvaraj in #30080 <details> <summary>🔧 Fixes</summary> - [The BindingContext of the Window TitleBar is not being passed on to its child content.](#24831) </details> - [Windows/Mac] Fix RTL FlowDirection causes overlap with native window control buttons in TitleBar by @devanathan-vaithiyanathan in #30400 <details> <summary>🔧 Fixes</summary> - [[Windows, Mac] RTL FlowDirection causes overlap with native window control buttons in TitleBar](#30399) </details> ## WebView - [Windows] Fix WebView background color not being applied by @SubhikshaSf4851 in #34599 <details> <summary>🔧 Fixes</summary> - [WebView background color has changed after update, can't override.](#34518) </details> - [Android] Fix for WebView/HybridWebView briefly flashes full screen before layout completes by @praveenkumarkarunanithi in #33207 <details> <summary>🔧 Fixes</summary> - [[Android] HybridWebView briefly resizes to full screen when page is opened before snapping back to correct size](#31475) </details> ## Xaml - Improved style inheritance by @kubaflo in #31317 <details> <summary>🔧 Fixes</summary> - [Styles based on a style that is based on another style that uses AppThemeBinding do not inherit properties correctly.](#31280) </details> - Fix for VisualStateManager Setter.TargetName failing when ControlTemplate is applied by @BagavathiPerumal in #33208 <details> <summary>🔧 Fixes</summary> - [Setter.TargetName + ControlTemplate crash](#26977) </details> <details> <summary>🧪 Testing (4)</summary> - [Testing] Additional Feature Matrix Event Test Cases for Slider and ScrollView by @nivetha-nagalingam in #34352 - [Testing] Fixed Build error on inflight/ candidate PR 34885 by @NafeelaNazhir in #34891 - [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by @NafeelaNazhir in #34933 - Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by @Dhivya-SF4094 in #34938 </details> <details> <summary>📦 Other (3)</summary> - Fix Loaded event not called for MAUI View added to native View by @NirmalKumarYuvaraj in #34345 <details> <summary>🔧 Fixes</summary> - [Loaded event not called for MAUI View added to native View](#34310) </details> - Add public IAlertManager and IAlertManagerSubscription interfaces by @Redth in #34228 <details> <summary>🔧 Fixes</summary> - [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`, `DisplayPromptAsync`) needs a public extensibility point](#34104) </details> - Fix crash when displaying alerts on unloaded pages by @kubaflo in #33288 </details> <details> <summary>📝 Issue References</summary> Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes #12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes #19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes #20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes #22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes #24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes #26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes #27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes #28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes #29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes #30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes #31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes #31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes #32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes #33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes #34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes #34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes #34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730 </details> **Full Changelog**: main...inflight/candidate

kubaflo requested a review from a team as a code owner December 27, 2024 23:49

kubaflo requested review from PureWeen and rmarinho December 27, 2024 23:49

dotnet-policy-service Bot added the community ✨ Community Contribution label Dec 27, 2024

kubaflo added the area-controls-modal label Dec 27, 2024

kubaflo force-pushed the Shell-PopToRootAsync-doesn't-happen-instantly branch from ab33933 to 09c6260 Compare December 28, 2024 00:16

kubaflo changed the title ~~[Android] PopToRootAsync for modal pages - improvements~~ [Android & iOS] PopToRootAsync for modal pages - improvements Dec 28, 2024

pictos approved these changes Dec 28, 2024

View reviewed changes

Comment thread src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.Android.cs Outdated

PureWeen added this to the .NET 9 SR4 milestone Jan 9, 2025

PureWeen requested changes Jan 29, 2025

View reviewed changes

PureWeen force-pushed the Shell-PopToRootAsync-doesn't-happen-instantly branch from 09c6260 to b6bb662 Compare February 3, 2025 21:59

PureWeen modified the milestones: .NET 9 SR4, .NET 9 SR5 Feb 3, 2025

kubaflo force-pushed the Shell-PopToRootAsync-doesn't-happen-instantly branch from b6bb662 to c5d6e7d Compare February 4, 2025 00:53

pictos reviewed Feb 4, 2025

View reviewed changes

Comment thread src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.cs Outdated

kubaflo force-pushed the Shell-PopToRootAsync-doesn't-happen-instantly branch from c5d6e7d to 10334fa Compare February 7, 2025 16:38

This comment was marked as off-topic.

Sign in to view

github-actions Bot force-pushed the Shell-PopToRootAsync-doesn't-happen-instantly branch from 10334fa to 6cd1144 Compare February 25, 2025 09:52

jfversluis requested a review from PureWeen February 25, 2025 09:54

kubaflo added the s/agent-fix-implemented PR author implemented the agent suggested fix label Mar 27, 2026

MauiBot added s/agent-review-incomplete s/agent-changes-requested AI agent recommends changes - found a better alternative or issues and removed s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-review-incomplete labels Mar 27, 2026

kubaflo mentioned this pull request Apr 1, 2026

Add standalone code-review skill with maintainer-sourced review rules #34265

Merged

kubaflo changed the title ~~[Android & iOS] PopToRootAsync for modal pages - improvements~~ [Android] PopToRootAsync for modal pages - improvements Apr 2, 2026

kubaflo changed the base branch from main to inflight/current April 2, 2026 11:39

kubaflo merged commit a93f47b into dotnet:inflight/current Apr 2, 2026
26 of 36 checks passed

github-project-automation Bot moved this from Ready To Review to Done in MAUI SDK Ongoing Apr 2, 2026

PureWeen mentioned this pull request Apr 14, 2026

April 14th, Candidate #34885

Merged

github-actions Bot locked and limited conversation to collaborators May 3, 2026

kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026

Uh oh!

Conversation

kubaflo commented Dec 27, 2024

Issues Fixed

Uh oh!

kubaflo commented Dec 27, 2024

Uh oh!

Uh oh!

gabsamples6 commented Dec 31, 2024

Uh oh!

Zack-G-I-T commented Jan 3, 2025

Uh oh!

kubaflo commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabsamples6 commented Jan 7, 2025

Uh oh!

kubaflo commented Jan 7, 2025

Uh oh!

gabsamples6 commented Jan 8, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Feb 1, 2025

Uh oh!

PureWeen commented Feb 3, 2025

Uh oh!

Uh oh!

PureWeen commented Feb 6, 2025

Uh oh!

kubaflo commented Feb 7, 2025

Uh oh!

This comment was marked as off-topic.

kubaflo commented Mar 27, 2026

Uh oh!

kubaflo commented Apr 1, 2026

Code Review — PR #26851

Independent Assessment

Reconciliation with PR Narrative

Findings

⚠️ PR title says "[Android & iOS]" but diff only touches Android

⚠️ Missing newline at end of test file

💡 HostApp deeply nested lambdas

Devil's Advocate

Verdict: LGTM

Uh oh!

kubaflo commented Apr 1, 2026

🟢 .NET MAUI Review - Approved

Independent Assessment

Reconciliation with PR Narrative

Findings

⚠️ PR title says "[Android & iOS]" but diff only touches Android

⚠️ Missing newline at end of test file

💡 HostApp deeply nested lambdas

Devil's Advocate

Verdict

Uh oh!

github-actions Bot commented Apr 1, 2026

🔍 Prior Fix Regression Check

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

kubaflo commented Jan 3, 2025 •

edited

Loading