Fix S.R.CS.Unsafe AssemblyVersion and move properties to Versioning.props#221
Fix S.R.CS.Unsafe AssemblyVersion and move properties to Versioning.props#221carlossanlop merged 4 commits intodotnet:mainfrom carlossanlop:FixUnsafeVersioning
Conversation
|
Disregard. I just noticed that the IsPackable property was already in Versioning.props. I reverted my commit. |
ericstj
left a comment
There was a problem hiding this comment.
I fixed this to ship upstack packages. I reviewed changes here and past versioning changes. I did not notice any other problems.
I also built a test application. It's a .NETFramework application that multi-targets to every supported version of .NETFramework.
I then run dotnet add package Id --prerelease for every package we build in maintenance packages with a feed to my locally built packages. This picks the latest from nuget / local build.
I then build this and look at the generated bindingRedirects to ensure none are required on any framework.
Here's my test if you'd like to try it.
testMP.zip
We might want to integrate something like this into the build.
Note that it must use packages, because the versioning problem only exists when combining things we already published with those built locally. If we just look at build output it will never require redirects.
|
Thanks both. Merging and queuing a new official build. |
This was missed due to being in a separate file.
These will now be in the same file as the other versioning ones, and will also affect the tests and resource versions but that would not be a problem.