Skip to content

[runtime] Adopt safer native compiler flags: Wignored-qualifiers #24068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Oct 23, 2025
Merged

[runtime] Adopt safer native compiler flags: Wignored-qualifiers #24068

rolfbjarne merged 1 commit into from
Oct 23, 2025

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Oct 22, 2025

Example warning:

macios/runtime/xamarin/runtime.h:232:14: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
  232 | const char * const      xamarin_get_original_working_directory_path ();

References:

Contributes towards #23023.

@rolfbjarne
[runtime] Adopt safer native compiler flags: Wignored-qualifiers
289a8a4 
Example warning:

```
macios/runtime/xamarin/runtime.h:232:14: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
  232 | const char * const      xamarin_get_original_working_directory_path ();
```

References:

* https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app
* https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero)

Contributes towards #23023.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 22, 2025

✅ [CI Build #289a8a4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 22, 2025

✅ [PR Build #289a8a4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 22, 2025

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 22, 2025

🚀 [CI Build #289a8a4] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@rolfbjarne rolfbjarne merged commit 53f7714 into main Oct 23, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/safer-flags-Wignored-qualifiers branch October 23, 2025 06:17
@rolfbjarne rolfbjarne linked an issue Oct 28, 2025 that may be closed by this pull request
Look into new security features with Xcode 26 #23023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Look into new security features with Xcode 26

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto