-
Notifications
You must be signed in to change notification settings - Fork 549
[release/9.0.1xx] [msbuild] Fix DetectSigningIdentity with entitlements in the simulator. Fixes #24032. #24059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0.1xx] [msbuild] Fix DetectSigningIdentity with entitlements in the simulator. Fixes #24032. #24059
Conversation
|
This should be backported to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #0d6c0b5] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #0d6c0b5] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #0d6c0b5] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #0d6c0b5] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #0d6c0b5] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #0d6c0b5] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #0d6c0b5] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #0d6c0b5] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #0d6c0b5] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
| EntitlementsInExecutable = new TaskItem (simulatedXcent); | ||
|
|
||
| // No matter what, I've only been able to make Xcode apply a single entitlement to simulator builds: com.apple.security.get-task-allow | ||
| // No matter what, I haven't been able to make Xcode apply any entitlements to the when signing simulator apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like something is missing in to the when
Fixes #24032. (#24076) * Always sign with the placeholder certificate '-' in the simulator. * We still need to find a provisioning profile (if required), and pass it on to the CompileEntitlements task, so that the CompileEntitlements task can adjust the entitlements (appending the team identifier for instance) before embedding them into the executable. Fixes #24032. Backport of #24059.
…nts in the simulator. Fixes #24032. (#24077) * Always sign with the placeholder certificate '-' in the simulator. * We still need to find a provisioning profile (if required), and pass it on to the CompileEntitlements task, so that the CompileEntitlements task can adjust the entitlements (appending the team identifier for instance) before embedding them into the executable. Fixes #24032. Backport of #24059.
Fixes #24032.