[msbuild] Ensure all resources are available on Windows before packing them. Fixes #23928. #23971
Conversation
…g them. Fixes #23928. Library projects might compile resources on the Mac before those compiled resources are embedded into the resulting assembly. However, some tasks will only create a 0-length stamp/output file on Windows, and we don't want to embed those 0-length files into the assembly. So if we find any such 0-length files, then copy them from the Mac to Windows before packing them. Fixes #23928.
✅ [CI Build #0955951] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #0955951] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #0955951] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #0955951] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #0955951] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #0955951] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #0955951] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #0955951] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
🚀 [CI Build #0955951] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 128 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
deleted the
dev/rolf/issue-23928-copy-resources-from-mac-to-windows-before-packing
branch
Library projects might compile resources on the Mac before those compiled
resources are embedded into the resulting assembly.
However, some tasks will only create a 0-length stamp/output file on Windows,
and we don't want to embed those 0-length files into the assembly.
So if we find any such 0-length files, then copy them from the Mac to Windows
before packing them.
Fixes #23928.