Skip to content

[release/9.0.1xx] [msbuild] Compute DOTNET_DiagnosticPorts using MSBuild properties. #23629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 7 commits into from
Aug 19, 2025
Merged

[release/9.0.1xx] [msbuild] Compute DOTNET_DiagnosticPorts using MSBuild properties. #23629

rolfbjarne merged 7 commits into from
Aug 19, 2025

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Aug 18, 2025 •
edited
Loading

If you run dotnet-dsrouter ios, it says:

Start an application on ios device with ONE of the following environment variables set:
[Default Tracing]
DOTNET_DiagnosticPorts=127.0.0.1:9000,nosuspend,listen
[Startup Tracing]
DOTNET_DiagnosticPorts=127.0.0.1:9000,suspend,listen

Setting $DOTNET_DiagnosticPorts is non-trivial, so as a step to simplify this, we are adding multiple MSBuild properties to configure this value.

This would allow the log message to say:

Build and run an iOS application such as:
[Default Tracing]
dotnet run -c Release -p:ios-arm64 -p:DiagnosticAddress=127.0.0.1 -p:DiagnosticPort=9000 -p:DiagnosticSuspend=false -p:DiagnosticListenMode=listen
[Startup Tracing]
dotnet run -c Release -p:ios-arm64 -p:DiagnosticAddress=127.0.0.1 -p:DiagnosticPort=9000 -p:DiagnosticSuspend=true -p:DiagnosticListenMode=listen

Since these are all default values, it can be simplified to:

Build and run an iOS application such as:
[Default Tracing]
dotnet run -p:ios-arm64 -c Release -p:EnableDiagnostics=true
[Startup Tracing]
dotnet run -p:ios-arm64 -c Release -p:EnableDiagnostics=true

Setting any of the new properties also implicitly means that $(EnableDiagnostics) is set to true (first example), or alternatively $(EnableDiagnostics) can be set to true to get the default value for all the new properties (second example).

Ref: dotnet/android#10351

Backport of #23429.

@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners August 18, 2025 12:29
@rolfbjarne rolfbjarne changed the title [release/9.0.1xx] Merge 06a3fb58d4653ac866dcaa0661769f5698a18ca8 into cddeadb513bfa0ee51bcd83d00d12656922e1f17 [release/9.0.1xx] [msbuild] Compute DOTNET_DiagnosticPorts using MSBuild properties. Aug 18, 2025
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

✅ [CI Build #9340760] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

✅ [CI Build #9340760] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

✅ [PR Build #9340760] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

💻 [CI Build #9340760] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

💻 [CI Build #9340760] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

💻 [CI Build #9340760] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

💻 [CI Build #9340760] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Aug 18, 2025

🚀 [CI Build #9340760] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 128 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 93407609d909607e936ddcde29e3a79beec1413b [PR build]

@rolfbjarne rolfbjarne merged commit 31f0e87 into release/9.0.1xx Aug 19, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/backport-pr-23429-release/9.0.1xx-2025-08-18 branch August 19, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque