[dotnet] Add support for the @(LinkerArgument) item group to pass arguments to the native linker. Fixes #21331. #23468
Conversation
…uments to the native linker. Fixes #21331. Quite often customers need to pass custom arguments to the native linker. Until now we haven't had an official way of doing this, besides the rather clunky: ```xml <AppBundleExtraOptions>$(AppBundleExtraOptions) --gcc_flags '...'</AppBundleExtraOptions> ``` So add support for the `LinkerArgument` item group, which will now serve this purpose. A code search on GitHub for '<LinkerArgument' shows exactly 1 result, which seems to be unrelated (it's for Java code), so hopefully no existing projects will already have 'LinkerArguments' set. Fixes #21331.
✅ [CI Build #9d4ed56] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #9d4ed56] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #9d4ed56] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #9d4ed56] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #9d4ed56] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #9d4ed56] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #9d4ed56] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
🚀 [CI Build #9d4ed56] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 121 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Quite often customers need to pass custom arguments to the native linker.
Until now we haven't had an official way of doing this, besides the rather clunky:
So add support for the
LinkerArgumentitem group, which will now serve this purpose.A code search on GitHub for '<LinkerArgument' shows exactly 1 result, which
seems to be unrelated (it's for Java code), so hopefully no existing projects
will already have 'LinkerArguments' set.
Fixes #21331.