[xcode26.0] Update tests to use SceneDelegate #23416

dalexsoto · 2025-07-29T07:15:33Z

tests/dotnet/BundleStructure/MacCatalyst/Info.plist

rolfbjarne · 2025-07-29T07:37:34Z

tests/common/AppDelegate.cs

 #endif
-#pragma warning disable CA1422
+
+#if __MACOS__


I'm assuming this is supposed to be:

Suggested change

#if __MACOS__

#if !__MACOS__

Yeah I did think the same when I was writing this but looks like it has been like that forever, there is no !__MACOS__ exclusion here and this code moved to SceneDelegate for all other platforms but macOS

macios/tests/common/AppDelegate.cs

Lines 27 to 46 in dd5577b

public override bool FinishedLaunching (UIApplication application, NSDictionary launchOptions)

{

#if __MACCATALYST__ || __MACOS__

TestRuntime.NotifyLaunchCompleted ();

#endif

var window = new UIWindow (UIScreen.MainScreen.Bounds);

var runner = new TouchRunner (window);

foreach (var assembly in TestLoader.GetTestAssemblies ())

runner.Add (assembly);

Window = window;

Runner = runner;

window.RootViewController = new UINavigationController (runner.GetViewController ());

window.MakeKeyAndVisible ();

PostFinishedLaunching ();

return true;

I guess the code can be removed then, because UIWindow doesn't exist on macOS, so I don't think this code is ever built on macOS.

mandel-macaque

Taking into account rolf comments.

vs-mobiletools-engineering-service2 · 2025-07-30T05:04:50Z

✅ [PR Build #d6720bf] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T05:07:03Z

✅ [CI Build #d6720bf] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T05:53:37Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T06:13:07Z

✅ [CI Build #d6720bf] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T06:22:32Z

💻 [CI Build #d6720bf] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T06:25:32Z

💻 [CI Build #d6720bf] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T06:27:15Z

💻 [CI Build #d6720bf] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-30T06:27:55Z

💻 [CI Build #d6720bf] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

rolfbjarne · 2025-07-30T09:37:20Z

tests/common/AppDelegate.cs

 #endif
-#pragma warning disable CA1422
+
+#if __MACOS__


I guess the code can be removed then, because UIWindow doesn't exist on macOS, so I don't think this code is ever built on macOS.

vs-mobiletools-engineering-service2 · 2025-07-30T15:23:20Z

🔥 [CI Build #d6720bf] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 114 tests passed.

Failures

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d6720bfbfa328ae4b78e149ff095a1de7f4b7841 [PR build]

[xcode26.0] Update tests to use SceneDelegate

41c3cdb

Fixes #23058

dalexsoto requested a review from rolfbjarne July 29, 2025 07:15

dalexsoto mentioned this pull request Jul 19, 2025

Update templates and tests to use UIScene life cycle #23058

Closed

4 tasks

GitHub Actions Autoformatter and others added 2 commits July 29, 2025 07:19

Auto-format source code

8feb503

Fix dict

27ea6ed

rolfbjarne requested changes Jul 29, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Jul 29, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Implement feedback

23d80ca

dalexsoto requested a review from rolfbjarne July 29, 2025 18:40

This comment has been minimized.

Sign in to view

Test fixes

d6720bf

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Jul 30, 2025

View reviewed changes

dalexsoto merged commit 6d1ec28 into xcode26.0 Jul 30, 2025
41 of 43 checks passed

dalexsoto deleted the dev/alex/xcode26Tests branch July 30, 2025 15:45

	public override bool FinishedLaunching (UIApplication application, NSDictionary launchOptions)
	{
	#if __MACCATALYST__ \|\| __MACOS__
	TestRuntime.NotifyLaunchCompleted ();
	#endif
	var window = new UIWindow (UIScreen.MainScreen.Bounds);

	var runner = new TouchRunner (window);
	foreach (var assembly in TestLoader.GetTestAssemblies ())
	runner.Add (assembly);

	Window = window;
	Runner = runner;

	window.RootViewController = new UINavigationController (runner.GetViewController ());
	window.MakeKeyAndVisible ();

	PostFinishedLaunching ();

	return true;

[xcode26.0] Update tests to use SceneDelegate #23416

[xcode26.0] Update tests to use SceneDelegate #23416

Uh oh!

Conversation

dalexsoto commented Jul 29, 2025

Uh oh!

Uh oh!

rolfbjarne Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

dalexsoto Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 30, 2025

✅ [PR Build #d6720bf] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

✅ [CI Build #d6720bf] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

✅ [CI Build #d6720bf] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

💻 [CI Build #d6720bf] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

💻 [CI Build #d6720bf] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

💻 [CI Build #d6720bf] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 30, 2025

💻 [CI Build #d6720bf] Tests on macOS arm64 - Mac Sequoia (15) passed 💻