Skip to content

[bgen] Improve the BI1078 error message to include the type name. #23349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Jul 17, 2025
Merged

[bgen] Improve the BI1078 error message to include the type name. #23349

rolfbjarne merged 1 commit into from
Jul 17, 2025

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jul 17, 2025

Old message:

error BI1078: bgen: Do not know how to make a signature for System.Object in method `get_ModifierFlags'

New message:

error BI1078: bgen: Do not know how to make a signature for System.Object in method `WebKit.WKNavigationAction.get_ModifierFlags'

@rolfbjarne
[bgen] Improve the BI1078 error message to include the type name.
83969ce 
Old message:

    error BI1078: bgen: Do not know how to make a signature for System.Object in method `get_ModifierFlags'

New message:

    error BI1078: bgen: Do not know how to make a signature for System.Object in method `WebKit.WKNavigationAction.get_ModifierFlags'
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

✅ [CI Build #83969ce] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

✅ [PR Build #83969ce] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

✅ [CI Build #83969ce] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

💻 [CI Build #83969ce] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

💻 [CI Build #83969ce] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

💻 [CI Build #83969ce] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

💻 [CI Build #83969ce] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 17, 2025

🚀 [CI Build #83969ce] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 83969ce9ffe2864b95dc4b2cca37fc6c0ddb5ca0 [PR build]

@rolfbjarne rolfbjarne merged commit 7c56d1f into main Jul 17, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/bgen-improve-bi1078 branch July 17, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto