[src] Stop using the MONOTOUCH and IPHONE defines. #23310

rolfbjarne · 2025-07-11T13:14:38Z

Use more accurate defines instead whenever applicable.

The XAMARIN_MODERN and SYSTEM_NET_HTTP defines are never used, so they can be
removed.

Also update the README.md file.

Once upon a time, over a decade ago, Xamarin.iOS and Xamarin.Mac were different in many ways, and a workaround was required for Xamarin.Mac. This is no longer the case, all our platforms are very similar, so make the code behave the same everywhere.

Use more accurate defines instead whenever applicable. The XAMARIN_MODERN and SYSTEM_NET_HTTP defines are never used, so they can be removed. Also update the README.md file.

…ch-define

vs-mobiletools-engineering-service2 · 2025-07-15T07:17:38Z

✅ [CI Build #baf30a8] Build passed (Build packages) ✅

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T07:19:29Z

✅ [PR Build #baf30a8] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T07:45:27Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T08:19:32Z

✅ [CI Build #baf30a8] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T08:28:21Z

💻 [CI Build #baf30a8] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T08:31:42Z

💻 [CI Build #baf30a8] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T08:32:59Z

💻 [CI Build #baf30a8] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T08:33:19Z

💻 [CI Build #baf30a8] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

vs-mobiletools-engineering-service2 · 2025-07-15T13:01:31Z

🚀 [CI Build #baf30a8] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 118 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: baf30a8b011baee577c903d6dee41ed5c70243ba [PR build]

rolfbjarne added 2 commits July 11, 2025 14:55

[src] Stop using the MONOTOUCH and IPHONE defines.

0d1a37f

Use more accurate defines instead whenever applicable. The XAMARIN_MODERN and SYSTEM_NET_HTTP defines are never used, so they can be removed. Also update the README.md file.

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jul 11, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Base automatically changed from dev/rolf/nsaction-unify to main July 14, 2025 12:34

Merge remote-tracking branch 'origin/main' into dev/rolf/stop-monotou…

c05cff8

…ch-define

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/stop-monotou…

baf30a8

…ch-define

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 4a375ec into main Jul 15, 2025
44 checks passed

rolfbjarne deleted the dev/rolf/stop-monotouch-define branch July 15, 2025 14:09

[src] Stop using the MONOTOUCH and IPHONE defines. #23310

[src] Stop using the MONOTOUCH and IPHONE defines. #23310

Uh oh!

Conversation

rolfbjarne commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 15, 2025

✅ [CI Build #baf30a8] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

✅ [PR Build #baf30a8] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

✅ [CI Build #baf30a8] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

💻 [CI Build #baf30a8] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

💻 [CI Build #baf30a8] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

💻 [CI Build #baf30a8] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 15, 2025

💻 [CI Build #baf30a8] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 15, 2025

🚀 [CI Build #baf30a8] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rolfbjarne commented Jul 11, 2025 •

edited

Loading