Skip to content

[CloudKit] Fix all the delegate signatures. #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mandel-macaque merged 3 commits into from
Jun 20, 2025
Merged

[CloudKit] Fix all the delegate signatures. #23090

mandel-macaque merged 3 commits into from
Jun 20, 2025

Conversation

@mandel-macaque
Copy link
Contributor

@mandel-macaque mandel-macaque commented Jun 19, 2025

Add the correct nullability to the delegates.

mandel-macaque and others added 2 commits June 19, 2025 11:02
@mandel-macaque
[CloudKit] Fix all the delegate signatures.
f7e2cb0 
Add the correct nullability to the delegates.
Auto-format source code
0436337
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 19, 2025

✅ [PR Build #0436337] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0436337fcd0487ac45b0ff142bdf0fbd02911c5c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 19, 2025

✅ [CI Build #0436337] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0436337fcd0487ac45b0ff142bdf0fbd02911c5c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 19, 2025

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f7e2cb03a9a856c4430cb2484bc8a6845a4e2a36 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 19, 2025

✅ [CI Build #0436337] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0436337fcd0487ac45b0ff142bdf0fbd02911c5c [PR build]

@mandel-macaque
Copy link
Contributor Author

mandel-macaque commented Jun 20, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 20, 2025

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@mandel-macaque
Copy link
Contributor Author

mandel-macaque commented Jun 20, 2025

/azp run xamarin-macios-pr

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

✅ [CI Build #41c23d7] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 41c23d75f51ade182949487785e2079df20ee0e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

✅ [PR Build #41c23d7] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 41c23d75f51ade182949487785e2079df20ee0e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

✅ [CI Build #41c23d7] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 41c23d75f51ade182949487785e2079df20ee0e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

💻 [CI Build #a98f92e] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a98f92ee63c8c7ed9be4b6301a54a03967f01387 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

💻 [CI Build #a98f92e] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a98f92ee63c8c7ed9be4b6301a54a03967f01387 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

💻 [CI Build #a98f92e] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a98f92ee63c8c7ed9be4b6301a54a03967f01387 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

💻 [CI Build #a98f92e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: a98f92ee63c8c7ed9be4b6301a54a03967f01387 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 41c23d75f51ade182949487785e2079df20ee0e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 20, 2025

🚀 [CI Build #a98f92e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a98f92ee63c8c7ed9be4b6301a54a03967f01387 [PR build]

@mandel-macaque mandel-macaque merged commit a4b9de4 into main Jun 20, 2025
10 of 12 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/cloudkit-delegates branch June 20, 2025 20:42
mandel-macaque added a commit that referenced this pull request Jun 21, 2025
@mandel-macaque
[CloudKit] Fix all the delegate signatures. (#23090)
00f04c6 
Add the correct nullability to the delegates.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
@mandel-macaque mandel-macaque mentioned this pull request Jun 24, 2025
Closed
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne