[msbuild] Fix build break. #22958
Merged
[msbuild] Fix build break. #22958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
macios/msbuild/Xamarin.MacDev.Tasks/Tasks/CompileEntitlements.cs(951,74): error CS8620: Argument of type 'KeyValuePair<string, PObject>' cannot be used for parameter 'kvp' of type 'KeyValuePair<string?, PObject>' in 'void CompileEntitlements.ValidateTypeOrArray<PString, string>(MobileProvision? profile, EntitlementInfo info, bool onlyWarn, string key, KeyValuePair<string?, PObject> kvp, string? provisioningProfileName, PDictionary? provisioningEntitlements, string requiredType)' due to differences in the nullability of reference types.
macios/msbuild/Xamarin.MacDev.Tasks/Tasks/CompileEntitlements.cs(956,73): error CS8620: Argument of type 'KeyValuePair<string, PObject>' cannot be used for parameter 'kvp' of type 'KeyValuePair<string?, PObject>' in 'void CompileEntitlements.ValidateTypeOrArray<PBoolean, bool>(MobileProvision? profile, EntitlementInfo info, bool onlyWarn, string key, KeyValuePair<string?, PObject> kvp, string? provisioningProfileName, PDictionary? provisioningEntitlements, string requiredType)' due to differences in the nullability of reference types.
Collaborator
✅ [CI Build #2291ac3] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #2291ac3] Build passed (Detect API changes) ✅Pipeline on Agent |
dalexsoto
approved these changes
May 30, 2025
Member
Author
|
Merging, since the build succeeded, which is already an improvement. |
Member
|
@rolfbjarne do we need this on 9.0? |
Member
Author
No, it broke after creating the merge PR from main to 9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: