[net10.0] [dotnet] Disable metrics support by default for non-Release builds #22389
Conversation
This saves ~191kb / 0.3% of app size on a minimal hello world iOS app. Apparently metrics exportation doesn't work if event sources are disabled, and we're already disabling that by default, so apparently this has never worked without modifying the project already.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
changed the title
✅ [CI Build #35ac58b] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #35ac58b] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #35ac58b] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #35ac58b] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #35ac58b] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #35ac58b] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
❌ [CI Build #35ac58b] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #35ac58b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🚀 [CI Build #35ac58b] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This saves ~191kb / 0.3% of app size on a minimal hello world iOS app.
Apparently metrics exportation doesn't work if event sources are disabled, and
we're already disabling that by default, so apparently this has never worked
without modifying the project already.
Android is already disabling this by default since .NET 8, but will be for non-Release builds in .NET 10 (dotnet/android#9928).
Ref: