Set default for UseSizeOptimizedLinq #22076

mandel-macaque · 2025-01-29T16:56:45Z

Sets the default for switch added in dotnet/sdk#46375.

(Should merge before we start consuming the SDK/runtime that has this.)

Supersedes PR #22074 so that we can run the CI

Sets the default for switch added in dotnet/sdk#46375. (Should merge before we start consuming the SDK/runtime that has this.)

jonathanpeppers

We already merged the Android version of this:

dotnet/android@f3ebc6f

rolfbjarne · 2025-02-10T16:21:26Z

Closing as dup of #22074.

rolfbjarne · 2025-02-10T16:22:24Z

Reopening, forgot about CI restrictions 😒

vs-mobiletools-engineering-service2 · 2025-02-12T18:58:42Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T18:59:14Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:24:20Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:40:39Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:41:31Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:41:51Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:48:48Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T19:51:46Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-12T20:07:31Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-13T07:17:55Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e479d6abc71a9c80b63e872f39c0ddb953aad928 [PR build]

Set default for UseSizeOptimizedLinq

a66a280

Sets the default for switch added in dotnet/sdk#46375. (Should merge before we start consuming the SDK/runtime that has this.)

This comment has been minimized.

Sign in to view

jonathanpeppers approved these changes Jan 31, 2025

View reviewed changes

rolfbjarne closed this Feb 10, 2025

rolfbjarne reopened this Feb 10, 2025

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/MichalStrehovsky/patch-1

f701d3e

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/MichalStrehovsky/patch-1

e479d6a

rolfbjarne mentioned this pull request Feb 12, 2025

Set default for UseSizeOptimizedLinq #22074

Closed

rolfbjarne self-assigned this Feb 12, 2025

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Feb 13, 2025

View reviewed changes

rolfbjarne merged commit f8b7ead into main Feb 13, 2025
47 checks passed

rolfbjarne deleted the dev/MichalStrehovsky/patch-1 branch February 13, 2025 07:25

Set default for UseSizeOptimizedLinq #22076

Set default for UseSizeOptimizedLinq #22076

Uh oh!

Conversation

mandel-macaque commented Jan 29, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jonathanpeppers left a comment

Choose a reason for hiding this comment

Uh oh!

rolfbjarne commented Feb 10, 2025

Uh oh!

rolfbjarne commented Feb 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ [PR Build] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 12, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 12, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 12, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 13, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants