[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

rolfbjarne · 2024-12-30T17:48:59Z

This involved a few changes:

Add Windows support to the msbuild tasks to compress using System.IO.Compression (as opposed to the zip command line tool) on Windows. This is required in order to create binding resource packages on Windows.
Create the binding resource package on Windows instead of remotely on macOS for remote builds.
Resolve native references on Windows instead of on macOS for remote builds.
Generate bindings (run the generator) on Windows instead of on macOS for remote builds, with an opt-out to keep doing it remotely if needed.
Compute _SdkIsSimulator from the RuntimeIdentifier, this way it's available much earlier in the build process.
Run several additional tests on Windows.
Misc other test improvements/additions.

Fixes #16244.
Fixes #16611.

rolfbjarne · 2024-12-30T17:49:03Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2024-12-30T17:49:26Z

Azure Pipelines successfully started running 2 pipeline(s).

rolfbjarne · 2024-12-31T09:00:03Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2024-12-31T09:00:39Z

Azure Pipelines successfully started running 2 pipeline(s).

emaf · 2025-03-18T16:48:09Z

msbuild/Xamarin.Shared/Xamarin.Shared.targets

-		Condition="'$(IsBindingProject)' == 'true' And '$(DesignTimeBuild)' != 'true'">
+		Condition="'$(IsBindingProject)' == 'true'">

-		<Warning Condition="'$(IsMacEnabled)' != 'true'" Text="It's currently not supported to build a binding project from Windows unless a connection to a Mac is available." />


Design time builds will always be executed "offline" as we don't pass any connection parameters from VS for those. We do this because designtime builds must be fast.

So I think we need to ensure 2 things:
1- We don't require remote builds during designtime builds.
2- We should not make the designtime build fail if the objc binding project cannot be processed entirely on Windows.

I re-instated the existing logic for design-time builds (not doing design-time builds for binding projects), we can do that in a separate PR later on.

…g-projects-on-windows

vs-mobiletools-engineering-service2 · 2025-03-19T08:05:23Z

✅ [CI Build #2b8dc11] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:07:14Z

✅ [PR Build #2b8dc11] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:14:49Z

✅ [CI Build #2b8dc11] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:28:55Z

💻 [CI Build #2b8dc11] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:29:54Z

💻 [CI Build #2b8dc11] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:30:42Z

💻 [CI Build #2b8dc11] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:31:13Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T08:57:24Z

💻 [CI Build #2b8dc11] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T13:46:54Z

💻 [CI Build #2b8dc11] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

vs-mobiletools-engineering-service2 · 2025-03-19T16:50:39Z

🚀 [CI Build #2b8dc11] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2b8dc11fef8b252e8e423e40fe2643d95ffbf8ea [PR build]

rolfbjarne · 2025-03-19T17:09:41Z

do-not-merge until we've released Xcode 16.3 support, so that we don't add too many potentially disruptive features in our Xcode 16.3 release.

dalexsoto

@rolfbjarne Agreed on keeping this one on hold until Xcode 16.3 is out, should we put it back as a draft for now?

rolfbjarne mentioned this pull request Dec 30, 2024

[DRAFT] Build binding projects on Windows instead of remotely. Fixes #16244. #18766

Closed

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review March 18, 2025 15:24

rolfbjarne requested review from emaf and mauroa as code owners March 18, 2025 15:24

emaf reviewed Mar 18, 2025

View reviewed changes

rolfbjarne added 2 commits March 19, 2025 08:42

[msbuild] Don't touch design time builds yet.

4bb8b2a

Merge remote-tracking branch 'origin/main' into dev/rolf/build-bindin…

2b8dc11

…g-projects-on-windows

This comment has been minimized.

Sign in to view

emaf approved these changes Mar 19, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added the do-not-merge Do not merge this pull request label Mar 19, 2025

dalexsoto approved these changes Mar 21, 2025

View reviewed changes

rolfbjarne mentioned this pull request Mar 25, 2025

[net10.0] Fix a few test failures introduced in #21979. #22178

Closed

rolfbjarne marked this pull request as draft March 28, 2025 13:38

rolfbjarne marked this pull request as ready for review April 2, 2025 12:40

rolfbjarne merged commit 4561f08 into main Apr 2, 2025
47 checks passed

rolfbjarne deleted the dev/rolf/build-binding-projects-on-windows branch April 2, 2025 12:42

rolfbjarne mentioned this pull request Apr 7, 2025

'nuget pack' doesn't work on Windows with binding resource packages #21000

Closed

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

Uh oh!

Conversation

rolfbjarne commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolfbjarne commented Dec 30, 2024

Uh oh!

azure-pipelines bot commented Dec 30, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 31, 2024

Uh oh!

azure-pipelines bot commented Dec 31, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

emaf Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

✅ [CI Build #2b8dc11] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

✅ [PR Build #2b8dc11] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

✅ [CI Build #2b8dc11] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

💻 [CI Build #2b8dc11] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

💻 [CI Build #2b8dc11] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

💻 [CI Build #2b8dc11] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 19, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 19, 2025

💻 [CI Build #2b8dc11] Windows Integration Tests passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 19, 2025

💻 [CI Build #2b8dc11] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 19, 2025

rolfbjarne commented Dec 30, 2024 •

edited

Loading