[Foundation] NSUrlSessionHandler: Adds support for X509 client certificates #21284

rolfbjarne · 2024-09-23T10:22:02Z

Addresses #13856

This was originally created by @dotMorten in #20434.

Also make SecIdentity.Import use an in-memory keychain on macOS 15+, so that
SecIdentity.Import works like all othe other platforms (i.e. not requiring
access to the default keychain, which, among other things, is not ideal on
bots).

…n in memory one (EphemeralKeySet).

… on macOS 15+.

vs-mobiletools-engineering-service2 · 2024-09-24T16:27:29Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T16:30:36Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T16:32:03Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T16:32:19Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T16:46:14Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T16:57:02Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-24T18:02:47Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

dotMorten

Ship it! :-) 🚢

vs-mobiletools-engineering-service2 · 2024-09-24T18:16:21Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 97 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3be26ada7d7177f696d401e8651042aa87969453 [PR build]

Morten Nielsen and others added 16 commits September 23, 2024 12:15

Adds support for X509 client certificates

1325e7a

Add certicate helper from .NET Runtime repro

f443251

Move certificate helper in as a private local class

257dfdb

Fully qualify type

636031e

Only include new functionality for NET builds

f34ded9

Fix code formatting

c7b65b4

Add unit test

a8886c0

Fix tests on macOS by not using the default keyset of the system by a…

ee2d96e

…n in memory one (EphemeralKeySet).

Move to exportable to fix the tests.

2bef14f

Add the persistent storage.

56a0758

Add documentation.

2583158

Seems to be that just adding exportable is enough.

30d46f9

Use platform-specific x509 flags, macOS isn't like other platforms.

9d0e5c5

Use temporary keychain when importing PKCS#12 data into a SecIdentity…

2d43afd

… on macOS 15+.

Don't run new test on macOS 14 or earlier.

70e4b16

Update cecil tests.

878218f

rolfbjarne requested review from dalexsoto and mandel-macaque as code owners September 23, 2024 10:22

rolfbjarne added the community Community contribution ❤ label Sep 23, 2024

rolfbjarne mentioned this pull request Sep 23, 2024

NSUrlSessionHandler: Adds support for X509 client certificates #20434

Closed

dalexsoto approved these changes Sep 23, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 24, 2024 16:27

Fix Xcode version check.

76336c5

Merge remote-tracking branch 'origin/main' into dev/rolf/x509

3be26ad

This comment has been minimized.

Sign in to view

dotMorten approved these changes Sep 24, 2024

View reviewed changes

rolfbjarne merged commit eabf3ab into main Sep 24, 2024

rolfbjarne deleted the dev/rolf/x509 branch September 24, 2024 21:44

rolfbjarne mentioned this pull request Sep 24, 2024

Extending NSUrlSessionHandler with client certificates #13856

Closed

[Foundation] NSUrlSessionHandler: Adds support for X509 client certificates #21284

[Foundation] NSUrlSessionHandler: Adds support for X509 client certificates #21284

Uh oh!

Conversation

rolfbjarne commented Sep 23, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 24, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

❌ [CI Build] Windows Integration Tests failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

dotMorten left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 24, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dotMorten left a comment •

edited

Loading