Skip to content

Do not include -dead_strip when native linking a NativeAOT object file#18553

Merged
dalexsoto merged 1 commit intodotnet:net8.0from
ivanpovazan:naot-disable-dead-strip
Jul 13, 2023
Merged

Do not include -dead_strip when native linking a NativeAOT object file#18553
dalexsoto merged 1 commit intodotnet:net8.0from
ivanpovazan:naot-disable-dead-strip

Conversation

@ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Jul 12, 2023 •
edited
Loading

This PR disables passing -dead_strip to the native linker in case of NativeAOT runtime to prevent build failures.

Additionally, this change affects the size of the application in the following way - measured with dotnet new maui app version 8.0.0-preview.7.23359.1:

MAUI iOS -dead_strip no -dead_strip diff (b) diff (Kb) diff (%)
.ipa (b) 13377583 13435276 57693 57,693 0,43%
Size on disk (b) 41883897 42038873 154976 154,976 0,37%
binary (b) 39614336 39769312 154976 154,976 0,39%

Even though the size of the application regresses, with this change we have a more stable product.

Finally, once this PR gets merged we can open a tracking issue to solve the size regression either by fixing:

Fixes: #18552

@ivanpovazan
Copy link
Member Author

ivanpovazan commented Jul 12, 2023

/cc: @akoeplinger

@ivanpovazan ivanpovazan requested a review from akoeplinger July 12, 2023 12:14
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 12, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 12, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: f9cdf53b448bf1e4be7d6a99cab509b5a7a1d3fe [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 12, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 12, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 12, 2023

✅ API diff for current PR / commit

NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f9cdf53b448bf1e4be7d6a99cab509b5a7a1d3fe [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jul 13, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 92 tests passed 🎉

Tests counts

⚠️ bcl: No tests selected. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download
⚠️ install_source: No tests selected. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch: All 26 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f9cdf53b448bf1e4be7d6a99cab509b5a7a1d3fe [PR build]

@dalexsoto dalexsoto merged commit f212f6b into dotnet:net8.0 Jul 13, 2023
@rolfbjarne rolfbjarne mentioned this pull request Aug 1, 2023
Closed
@ivanpovazan ivanpovazan mentioned this pull request Aug 2, 2023
Closed
ivanpovazan added a commit that referenced this pull request Jul 1, 2024
@ivanpovazan
Revert "Do not include -dead_strip when native linking a NativeAOT ob…
a613bd6 
…ject file (#18553)"

This reverts commit f212f6b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

+1 more reviewer

@filipnavara filipnavara filipnavara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ivanpovazan @vs-mobiletools-engineering-service2 @dalexsoto @akoeplinger @filipnavara