[Localization] Set OneLocBuild Task to not delete Lego Branch #16909
Conversation
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
In our localization process, the Loc team builds the translations (in the not-user-readable .lcl files) and merges them into the 'Localization' branch from a 'Lego/...' branch. After this happens, our 'Get Localization Translations' github action takes that commits and creates a PR into main with those changes. It is really important that this github action works because we will later delete the 'Localization' branch and create a new one from the 'main' branch so that the branches stay in sync. There worked fine, but there is now a 'isDeletePrSourceBranchSelected' input to the OneLocBuild task that defaults to true that deletes the 'Lego/...' branch right after the commit to 'Localization' is made. Due to this, the github action cannot bring the commit to 'main' because the 'Lego/...' branch no longer exists. The hope is that setting this input to false will successfully not delete the 'Lego/...' branch allowing the rest of the flow to be uninterrupted. Co-authored-by: TJ Lambert <[email protected]>
3 participants
In our localization process, the Loc team builds the translations (in the not-user-readable .lcl files) and merges them into the 'Localization' branch from a 'Lego/...' branch. After this happens, our 'Get Localization Translations' github action takes that commits and creates a PR into main with those changes. It is really important that this github action works because we will later delete the 'Localization' branch and create a new one from the 'main' branch so that the branches stay in sync.
There worked fine, but there is now a 'isDeletePrSourceBranchSelected' input to the OneLocBuild task that defaults to true that deletes the 'Lego/...' branch right after the commit to 'Localization' is made. Due to this, the github action cannot bring the commit to 'main' because the 'Lego/...' branch no longer exists.
The hope is that setting this input to false will successfully not delete the 'Lego/...' branch allowing the rest of the flow to be uninterrupted.