Skip to content

[devops] Skip a few steps if something goes wrong. #16756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Nov 15, 2022
Merged

[devops] Skip a few steps if something goes wrong. #16756

rolfbjarne merged 1 commit into from
Nov 15, 2022

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Nov 15, 2022

There's no need to:

  • Check for HD space.
  • Make mlaunch verbose.
  • Reset launchctl.

if something else already went wrong in a test run.

@rolfbjarne
[devops] Skip a few steps if something goes wrong.
85e8736 
There's no need to:

* Check for HD space.
* Make mlaunch verbose.
* Reset launchctl.

if something else already went wrong in a test run.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2022

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 85e873677cd067369653b6456559f4ee3d4286e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 85e873677cd067369653b6456559f4ee3d4286e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2022

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-010.Monterey'
Hash: 85e873677cd067369653b6456559f4ee3d4286e6 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Nov 15, 2022

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ mtouch tests

1 tests failed, 0 tests passed.
Details
  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Nov 15, 2022

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2631).

@rolfbjarne rolfbjarne merged commit ad55eb6 into dotnet:main Nov 15, 2022
@rolfbjarne rolfbjarne deleted the devops-skip-if-broken branch November 15, 2022 17:20
mandel-macaque pushed a commit that referenced this pull request Mar 3, 2023
@rolfbjarne @mandel-macaque
[devops] Skip a few steps if something goes wrong. (#16756)
cafe1f3 
There's no need to:

* Check for HD space.
* Make mlaunch verbose.
* Reset launchctl.

if something else already went wrong in a test run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tj-devel709 tj-devel709 tj-devel709 approved these changes

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @mandel-macaque @tj-devel709