Skip to content

Conversation

@stephentoub
Copy link
Member

Reverts #257

This is no longer needed, as:

cc: @CESARDELATORRE

@CESARDELATORRE
Copy link
Contributor

Reverts #257
This is no longer needed, as:

dotnet/machinelearning#2630 made supportSparse default to false. And even if it wasn't changed....
dotnet/machinelearning#2579 made supportSparse faster when it is true, in particular when the debugger is attached.

cc: @CESARDELATORRE

But that is for v0.11, right? - We have the v0.11 migration (work in progress) in this other branch:
https://github.com/dotnet/machinelearning-samples/tree/migration/v.11

Master branch is still v0.10 until v0.11 NuGet package is released at the main NuGet feed.

@stephentoub
Copy link
Member Author

But that is for v0.11, right?

Yes.

We have the v0.11 migration (work in progress) in this other branch:

Ok. Would you like to:
a) Leave this open and merge it once 0.11 is released?
b) Merge it now anyway? (It really only affects perf while the debugger is attached, and this simplifies the sample.)
c) Close it and have me open a new PR to that other branch?

@CESARDELATORRE
Copy link
Contributor

Agree. This is not really impacting strongly on 0.10. I'll merge here and it'll be better by updating to 0.11 when we merge 0.11 branch. Thanks! 👍

@CESARDELATORRE CESARDELATORRE merged commit 4ac99e7 into master Mar 5, 2019
@CESARDELATORRE CESARDELATORRE deleted the revert-257-disablesparse branch August 23, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants