Repository navigation
[release/6.0] Backport native dependency installer from #7760 - #7902
Conversation
Add only the executable dependency-install wrapper required by Copilot review setup on release/6.0. Co-authored-by: Copilot <[email protected]> Copilot-Session: c994e9a3-e808-41bd-92b6-f7f1d8791b8b
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
ID_LIKEin/etc/os-releasecan contain multiple space-separated values (e.g.,ubuntu debian),… · Newaptis not considered stable for non-interactive scripting (it may emit warnings and behavior can… · New$osis derived from the init script (no CLI arg), it’s not re-normalized to lower-case… · New$osis derived from the init script (no CLI arg), it’s not re-normalized to lower-case… · New
What changed in this PR
Adds the missing eng/install-dependencies.sh wrapper to release/6.0 so tooling that expects this entry point (e.g., Copilot review setup invoking sudo ./eng/install-dependencies.sh) can successfully install native dependencies, including OpenMP.
Changes:
- Add
eng/install-dependencies.shwrapper delegating to Arcade’s native dependency installer - Add Linux/OpenMP package installation for common distros and Homebrew
libompfor Apple platforms
| File | Description |
|---|---|
| eng/install-dependencies.sh | Introduces the expected dependency-install entry point and adds OpenMP installation on supported OSes |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.0 #7902 +/- ##
==============================================
Coverage ? 70.26%
==============================================
Files ? 1419
Lines ? 272603
Branches ? 27940
==============================================
Hits ? 191534
Misses ? 73654
Partials ? 7415
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the dependency-installer entry point added for Copilot review setup on release/6.0.
No open issues 🎉
4 resolved since last review
aptis not considered stable for non-interactive scripting (it may emit warnings and behavior can…ID_LIKEin/etc/os-releasecan contain multiple space-separated values (e.g.,ubuntu debian),…$osis derived from the init script (no CLI arg), it’s not re-normalized to lower-case…$osis derived from the init script (no CLI arg), it’s not re-normalized to lower-case…
Review effort: Balanced
Summary
Partial backport of #7760 to
release/6.0: add onlyeng/install-dependencies.sh, unchanged from the original PR and preserving its executable bit.Why this is needed
Copilot code review uses the setup configuration from
main, which invokessudo ./eng/install-dependencies.sh, while checking out the PR's code. The wrapper is missing fromrelease/6.0, so review setup for #7896 failed before dependency installation:See the failure comment and workflow run.
Adding the wrapper supplies the entry point expected by that setup configuration. It delegates to the existing Arcade dependency installer and adds OpenMP installation.
Why only this part is backported
The missing wrapper is sufficient to explain and fix this specific setup failure. Its required helper scripts already exist on
release/6.0; no Arcade update is needed.The release branch's own setup workflow already installs the Arcade dependencies and
libomp-devdirectly, so changing it is unnecessary for this fix. The remaining documentation, test cleanup, and CI call-site changes from #7760 are unrelated to the missing entry point and would expand the servicing change without helping resolve this failure.Validation
100755.Note
This PR description and backport were prepared with GitHub Copilot.