Repository navigation
Enable CastGuard in Windows native builds - #7793
Merged
Merged
Conversation
Generate compiler debug metadata with /Z7 and retain CFG. Resolve the newly visible oneDAL compiler-warning errors without suppressions, check narrowing conversions, and document native build requirements. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a64691c7-3c54-4513-8fbf-ab39a2eb744b
Restore the original oneDAL umbrella header, warning suppressions, and source. Defer the SDK upgrade to #7792 and the associated narrowing-conversion cleanup to that follow-up. Retain /Z7 because adding /guard:cast alone still produces BA2028 for every native DLL in local reproduction. The focused patch clears CastGuard on x64/x86 but intentionally leaves the newly visible OneDalNative BA2007 finding (existing /wd4996 and /wd4267) for the follow-up, as agreed. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a64691c7-3c54-4513-8fbf-ab39a2eb744b
Keep the Windows build guide focused on the compiler prerequisite. Explain debug metadata and BinSkim verification in the pull request instead. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a64691c7-3c54-4513-8fbf-ab39a2eb744b
rosebyte
approved these changes
Oct 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
=======================================
Coverage 69.95% 69.96%
=======================================
Files 1419 1419
Lines 272603 272603
Branches 27562 27562
=======================================
+ Hits 190698 190714 +16
+ Misses 73718 73701 -17
- Partials 8187 8188 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/guard:castalongside the existing options./DEBUGoption with/Z7so the object files contain compiler debug metadata that BinSkim can use to verify the hardening settings./guard:cast.