Skip to content

Add doc for CreateSweepableEstimator, Parameter and SearchSpace #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LittleLittleCloud merged 3 commits into from
Apr 17, 2023
Merged

Add doc for CreateSweepableEstimator, Parameter and SearchSpace #6611

LittleLittleCloud merged 3 commits into from
Apr 17, 2023

Conversation

@LittleLittleCloud
Copy link
Member

@LittleLittleCloud LittleLittleCloud commented Mar 28, 2023

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#6589

luisquintanilla
luisquintanilla reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleLittleCloud sorry for the delay. I think it looks great. I added a few comments.

luisquintanilla
luisquintanilla approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LittleLittleCloud. LGTM. :shipit:

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #6611 (640ded5) into main (6002aa8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6611      +/-   ##
==========================================
- Coverage   68.39%   68.34%   -0.05%     
==========================================
  Files        1176     1176              
  Lines      248210   248210              
  Branches    25915    25915              
==========================================
- Hits       169759   169650     -109     
- Misses      71676    71794     +118     
+ Partials     6775     6766       -9
Flag Coverage Δ
Debug 68.34% <ø> (-0.05%) ⬇️
production 62.72% <ø> (-0.06%) ⬇️
test 88.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.SearchSpace/Parameter.cs 74.05% <ø> (ø)
src/Microsoft.ML.SearchSpace/SearchSpace.cs 83.40% <ø> (ø)

... and 6 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud merged commit 74cc3c4 into dotnet:main Apr 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@luisquintanilla luisquintanilla luisquintanilla approved these changes

Assignees

@LittleLittleCloud LittleLittleCloud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LittleLittleCloud @luisquintanilla