Skip to content

Make model path mandatory in export to ONNX. #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 1 commit into from
Aug 8, 2018
Merged

Make model path mandatory in export to ONNX. #641

codemzs merged 1 commit into from
Aug 8, 2018

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Aug 3, 2018

fixes #423

@codemzs codemzs requested review from wschin and zeahmed August 3, 2018 06:04
@codemzs
Copy link
Member Author

codemzs commented Aug 3, 2018

dotnet build Linux Build_Debug

@codemzs
Copy link
Member Author

codemzs commented Aug 3, 2018

@dotnet-bot test this please

zeahmed
zeahmed approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codemzs! looks good to me.

wschin
wschin approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codemzs codemzs merged commit 4b60064 into dotnet:master Aug 8, 2018
@codemzs codemzs deleted the onnx branch August 8, 2018 17:15
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@wschin wschin wschin approved these changes

@zeahmed zeahmed zeahmed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Onnx path parameter mandatory in OnnxConverter

3 participants

@codemzs @wschin @zeahmed