Fixes #5352 issues caused by equality with non-string values for root cause localization #5354
Merged
harishsk merged 5 commits intodotnet:masterfrom Aug 25, 2020
Merged
Conversation
|
|
lisahua
suggested changes
Aug 19, 2020
lisahua
reviewed
Aug 19, 2020
yeeyang19
commented
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #5354 +/- ##
==========================================
- Coverage 74.04% 71.45% -2.60%
==========================================
Files 1019 1019
Lines 190035 190163 +128
Branches 20457 20459 +2
==========================================
- Hits 140720 135881 -4839
- Misses 43783 48831 +5048
+ Partials 5532 5451 -81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lisahua
approved these changes
Aug 21, 2020
Contributor
lisahua
left a comment
lisahua
left a comment
There was a problem hiding this comment.
Thanks for adding tests. LEave some styling suggestions.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5352
Comparison between dimension value and aggregated symbol failed or got the incorrect result when their values weren't string.
Need to support nullable object as the dimension value and aggregated symbol, so we use Object.Equals(a, b) instead of a == b and a.Equals(b).
Besides, I replace object using Object to align with the data type of dimension and aggregated symbol in this extension.