Aded catch in R^2 calculation for case with few samples#5319
Merged
harishsk merged 4 commits intodotnet:masterfrom Jul 26, 2020
Merged
Aded catch in R^2 calculation for case with few samples#5319harishsk merged 4 commits intodotnet:masterfrom
harishsk merged 4 commits intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5319 +/- ##
==========================================
- Coverage 73.98% 73.91% -0.08%
==========================================
Files 1019 1019
Lines 190083 190101 +18
Branches 20437 20438 +1
==========================================
- Hits 140641 140509 -132
- Misses 43924 44060 +136
- Partials 5518 5532 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kere-nel
previously requested changes
Jul 22, 2020
kere-nel
reviewed
Jul 25, 2020
kere-nel
reviewed
Jul 25, 2020
justinormont
approved these changes
Jul 26, 2020
Contributor
justinormont
left a comment
justinormont
left a comment
There was a problem hiding this comment.
LGTM, left a comment above about the unit test.
harishsk
approved these changes
Jul 26, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5306 by adding a catch for the calculation of
R^2during metric calculation. When there is less than two rows of data used for the calculation ofR^2, the returned value becomes-Infinity, whereas it should be returningNaN.An example of this behavior in another ML framework is in scikit-learn, in the following lines:
https://github.com/scikit-learn/scikit-learn/blob/fd237278e895b42abe8d8d09105cbb82dc2cbba7/sklearn/metrics/_regression.py#L587-L590