Test fix using breastcancel dataset and test cleanup#5292
Merged
frank-dong-ms-zz merged 3 commits intodotnet:masterfrom Jul 8, 2020
Merged
Test fix using breastcancel dataset and test cleanup#5292frank-dong-ms-zz merged 3 commits intodotnet:masterfrom
frank-dong-ms-zz merged 3 commits intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5292 +/- ##
==========================================
- Coverage 73.75% 73.68% -0.07%
==========================================
Files 1022 1022
Lines 190360 190360
Branches 20472 20472
==========================================
- Hits 140401 140272 -129
- Misses 44442 44558 +116
- Partials 5517 5530 +13
|
mstfbl
approved these changes
Jul 8, 2020
Contributor
mstfbl
left a comment
mstfbl
left a comment
There was a problem hiding this comment.
I noticed that "breast-cancer-withheader.txt" does not have its own TextDataset breastCancerWithHeaderPipe in Datasets.cs, perhaps we can add that too here in the future.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is part of below PR, we decide to hold the text loader PR but this test fix can be merged separately:
#5275
2 fixes in this PR: