Refactor of OnnxConversionTests.cs#5185
Merged
michaelgsharp merged 2 commits intodotnet:masterfrom Jun 2, 2020
Merged
Conversation
…ts that can, removing about 400 lines of duplicate code.
Codecov Report
@@ Coverage Diff @@
## master #5185 +/- ##
==========================================
- Coverage 73.32% 73.29% -0.04%
==========================================
Files 1007 1007
Lines 188386 188016 -370
Branches 20286 20257 -29
==========================================
- Hits 138126 137797 -329
+ Misses 44736 44693 -43
- Partials 5524 5526 +2
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of the tests in OnnxConversionTests.cs do the same thing. Build an ML.Net pipeline, export it to ONNX, and compare the results. This PR refactors the OnnxConversionTests.cs file to use a common method for all the tests that do that same functionality, removing about 400 lines of duplicate code. There were a few tests with functionality not exactly the same, and those were left as is.