update codegen to make it work with mlnet 1.5 #5173
Merged
LittleLittleCloud merged 20 commits intodotnet:masterfrom Jul 20, 2020
Merged
update codegen to make it work with mlnet 1.5 #5173LittleLittleCloud merged 20 commits intodotnet:masterfrom
LittleLittleCloud merged 20 commits intodotnet:masterfrom
Conversation
| <PackageReference Include="Microsoft.ML" Version="StablePackageVersion" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxTransformer" Version="StablePackageVersion" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxRuntime" Version="1.2.3" /> | ||
| <PackageReference Include="Microsoft.ML.CodeGenerator.Helper" Version="1.2.3" /> |
Contributor
There was a problem hiding this comment.
What is Microsoft.ML.CodeGenerator.Helper? Is the code for it included in this PR?
Member
Author
There was a problem hiding this comment.
It's a helper package which includes customer transformer,
See this issue for detail into
dotnet/machinelearning-modelbuilder#397
| <PackageReference Include="Microsoft.ML" Version="StablePackageVersion" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxTransformer" Version="StablePackageVersion" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxRuntime" Version="1.2.3" /> | ||
| <PackageReference Include="Microsoft.ML.CodeGenerator.Helper" Version="1.2.3" /> |
Contributor
There was a problem hiding this comment.
Why a pinned version for Microsoft.ML.OnnxRuntime & Microsoft.ML.CodeGenerator.Helper?
Member
Author
There was a problem hiding this comment.
Because Microsoft.ML.OnnxTransformer 1.5.0 requires users to indicate the specific onnxruntime package (CPU or GPU)
Member
Author
There was a problem hiding this comment.
Not any more
Resolved
LittleLittleCloud
force-pushed
the
u/xiaoyun/updateCodeGenTo1.5
branch
from
5bbb389 to
787dec3
Compare
Codecov Report
@@ Coverage Diff @@
## master #5173 +/- ##
==========================================
+ Coverage 73.46% 73.72% +0.25%
==========================================
Files 1014 1011 -3
Lines 188682 188077 -605
Branches 20330 20278 -52
==========================================
+ Hits 138621 138652 +31
+ Misses 44540 43926 -614
+ Partials 5521 5499 -22
|
JakeRadMSFT
approved these changes
Jul 20, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue:
dotnet/machinelearning-modelbuilder#777