Skip to content

[AutoML] CLI CodeGen printing L1 instead of RMS #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinormont wants to merge 2 commits into from
Closed

[AutoML] CLI CodeGen printing L1 instead of RMS #3459

justinormont wants to merge 2 commits into from

Conversation

@justinormont
Copy link
Contributor

@justinormont justinormont commented Apr 22, 2019

CodeGen was printing the L1 Error in the RMS field.

=============== Cross-validating to get model's accuracy metrics ===============
*************************************************************************************************************
*       Metrics for Regression model      
*------------------------------------------------------------------------------------------------------------
*       Average L1 Loss:    298.351 
*       Average L2 Loss:    186688.889  
*       Average RMS:          298.351  
*       Average Loss Function: 186688.889  
*       Average R-squared: 0.687  
*************************************************************************************************************
=============== Training  model ===============
=============== End of training process ===============
=============== Saving the model  ===============
The model is saved to /private/tmp/blah/openfoodfactsIngredientsToCalories/openfoodfactsIngredientsToCalories.ConsoleApp/bin/Release/netcoreapp2.1/../../../../OpenfoodfactsIngredientsToCalories.Model/MLModel.zip

Notice the 298.351 twice.

@justinormont justinormont added the AutoML.NET Automating various steps of the machine learning process label Apr 22, 2019
srsaggam
srsaggam approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@srsaggam srsaggam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this,

srsaggam
srsaggam reviewed Apr 22, 2019
View reviewed changes
src/mlnet/Templates/Console/ModelBuilder.tt
var RMS = crossValidationResults.Select(r => r.Metrics.MeanAbsoluteError);
var RMS = crossValidationResults.Select(r => r.Metrics.RootMeanSquaredError);
var lossFunction = crossValidationResults.Select(r => r.Metrics.LossFunction);
var R2 = crossValidationResults.Select(r => r.Metrics.RSquared);
Copy link
Member

@srsaggam srsaggam Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong in here. Looks like you have changed tt file but no corresponding change in .cs file.

srsaggam
srsaggam requested changes Apr 22, 2019
View reviewed changes
Copy link
Member

@srsaggam srsaggam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong with template generation code. Need to update .cs files
Not sure how you updated the tt file without changes to its respective cs file. Are you using any other editor other than visual studio to edit the template?

@srsaggam srsaggam mentioned this pull request Apr 22, 2019
Merged
@srsaggam
Copy link
Member

srsaggam commented Apr 22, 2019

Fixed this issue in above referenced PR

@srsaggam srsaggam closed this Apr 22, 2019
@justinormont
Copy link
Contributor Author

justinormont commented Apr 22, 2019

Thanks @srsaggam. PR is closed and the same changed in created in #3504.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@srsaggam srsaggam srsaggam requested changes

@daholste daholste Awaiting requested review from daholste

Assignees

No one assigned

Labels

AutoML.NET Automating various steps of the machine learning process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinormont @srsaggam