Skip to content

XML documentation for LightGBM Ranking trainer. #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 3 commits into from
Apr 20, 2019
Merged

XML documentation for LightGBM Ranking trainer. #3431

codemzs merged 3 commits into from
Apr 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 19, 2019

towards #2522

@codemzs codemzs requested review from natke and shmoradims April 19, 2019 01:16
@shmoradims shmoradims mentioned this pull request Apr 19, 2019
Closed
@codecov
Copy link

codecov bot commented Apr 19, 2019 •
edited
Loading

Codecov Report

Merging #3431 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
- Coverage   72.73%   72.72%   -0.01%     
==========================================
  Files         807      807              
  Lines      145206   145206              
  Branches    16230    16230              
==========================================
- Hits       105614   105607       -7     
- Misses      35175    35181       +6     
- Partials     4417     4418       +1
Flag Coverage Δ
#Debug 72.72% <100%> (-0.01%) ⬇️
#production 68.27% <100%> (-0.01%) ⬇️
#test 88.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.FastTree/FastTreeRegression.cs 54.5% <ø> (ø) ⬆️
src/Microsoft.ML.LightGbm/LightGbmCatalog.cs 100% <ø> (ø) ⬆️
...rc/Microsoft.ML.FastTree/FastTreeClassification.cs 78.19% <ø> (ø) ⬆️
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 59.9% <ø> (ø) ⬆️
...icrosoft.ML.FastTree/RandomForestClassification.cs 78.07% <ø> (ø) ⬆️
...rc/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs 79.03% <100%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️

@codemzs codemzs force-pushed the lightgbmrankingdoc branch from ef2e837 to 4dcfd80 Compare April 19, 2019 23:20
shmoradims
shmoradims approved these changes Apr 19, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

shmoradims
shmoradims reviewed Apr 19, 2019
View reviewed changes
shmoradims
shmoradims reviewed Apr 19, 2019
View reviewed changes
natke
natke suggested changes Apr 19, 2019
View reviewed changes
@codemzs codemzs requested a review from natke April 19, 2019 23:37
singlis
singlis approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@singlis singlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 35bc449 into dotnet:master Apr 20, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@natke natke Awaiting requested review from natke

2 more reviewers

@shmoradims shmoradims shmoradims approved these changes

@singlis singlis singlis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codemzs @natke @shmoradims @singlis