Skip to content

XML documentation for Randomized PCA trainer. #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 3 commits into from
Apr 21, 2019
Merged

XML documentation for Randomized PCA trainer. #3429

codemzs merged 3 commits into from
Apr 21, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 19, 2019

towards #2522

@codemzs codemzs requested review from natke and shmoradims April 19, 2019 01:02
@shmoradims shmoradims mentioned this pull request Apr 19, 2019
Closed
@singlis singlis added the documentation Related to documentation of ML.NET label Apr 19, 2019
@codecov
Copy link

codecov bot commented Apr 19, 2019 •
edited
Loading

Codecov Report

Merging #3429 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3429      +/-   ##
==========================================
- Coverage   72.76%   72.73%   -0.04%     
==========================================
  Files         808      807       -1     
  Lines      145452   145206     -246     
  Branches    16244    16230      -14     
==========================================
- Hits       105842   105615     -227     
+ Misses      35189    35174      -15     
+ Partials     4421     4417       -4
Flag Coverage Δ
#Debug 72.73% <ø> (-0.04%) ⬇️
#production 68.27% <ø> (-0.01%) ⬇️
#test 88.98% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
src/Microsoft.ML.PCA/PCACatalog.cs 92.3% <ø> (ø) ⬆️
src/Microsoft.ML.PCA/PcaTrainer.cs 79.94% <ø> (ø) ⬆️
...s/Api/CookbookSamples/CookbookSamplesDynamicApi.cs 93.49% <0%> (-2%) ⬇️
.../Evaluators/Metrics/BinaryClassificationMetrics.cs 95% <0%> (-0.24%) ⬇️
test/Microsoft.ML.Functional.Tests/Common.cs 98.23% <0%> (-0.16%) ⬇️
src/Microsoft.ML.Data/Evaluators/EvaluatorUtils.cs 73.57% <0%> (-0.08%) ⬇️
...ta/Evaluators/MulticlassClassificationEvaluator.cs 77.69% <0%> (-0.04%) ⬇️
src/Microsoft.ML.TimeSeries/IidSpikeDetector.cs 72.54% <0%> (ø) ⬆️
...luators/Metrics/MulticlassClassificationMetrics.cs 100% <0%> (ø) ⬆️
src/Microsoft.ML.Recommender/RecommenderCatalog.cs 70.83% <0%> (ø) ⬆️
... and 36 more

shmoradims
shmoradims reviewed Apr 20, 2019
View reviewed changes
natke
natke reviewed Apr 20, 2019
View reviewed changes
wschin
wschin reviewed Apr 20, 2019
View reviewed changes
wschin
wschin reviewed Apr 20, 2019
View reviewed changes
wschin
wschin reviewed Apr 20, 2019
View reviewed changes
@shmoradims shmoradims mentioned this pull request Apr 20, 2019
Closed
shmoradims
shmoradims approved these changes Apr 21, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 548f323 into dotnet:master Apr 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@shauheen shauheen shauheen left review comments

@wschin wschin wschin left review comments

@natke natke natke approved these changes

@shmoradims shmoradims shmoradims approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@codemzs @shauheen @natke @wschin @shmoradims @singlis