Skip to content

XML documentation for Online Gradient Descent trainer. #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemzs merged 3 commits into from
Apr 20, 2019
Merged

XML documentation for Online Gradient Descent trainer. #3422

codemzs merged 3 commits into from
Apr 20, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 18, 2019

towards #2522

@codemzs codemzs requested review from natke, sfilipi and shmoradims April 18, 2019 23:54
@shmoradims shmoradims mentioned this pull request Apr 18, 2019
Closed
@codecov
Copy link

codecov bot commented Apr 19, 2019 •
edited
Loading

Codecov Report

Merging #3422 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
+ Coverage   72.73%   72.76%   +0.03%     
==========================================
  Files         807      808       +1     
  Lines      145206   145452     +246     
  Branches    16230    16244      +14     
==========================================
+ Hits       105618   105841     +223     
- Misses      35171    35190      +19     
- Partials     4417     4421       +4
Flag Coverage Δ
#Debug 72.76% <ø> (+0.03%) ⬆️
#production 68.27% <ø> (ø) ⬆️
#test 89.04% <ø> (+0.05%) ⬆️
Impacted Files Coverage Δ
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <ø> (ø) ⬆️
...dTrainers/Standard/Online/OnlineGradientDescent.cs 92.3% <ø> (ø) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.26% <0%> (-0.63%) ⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.73% <0%> (-0.33%) ⬇️
...ft.ML.Data/Evaluators/BinaryClassifierEvaluator.cs 77.18% <0%> (-0.01%) ⬇️
...luators/Metrics/MulticlassClassificationMetrics.cs 100% <0%> (ø) ⬆️
src/Microsoft.ML.Recommender/RecommenderCatalog.cs 70.83% <0%> (ø) ⬆️
...LogisticRegression/MulticlassLogisticRegression.cs 67.61% <0%> (ø) ⬆️
...soft.ML.Transforms/Text/WrappedTextTransformers.cs 93.63% <0%> (ø) ⬆️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (ø) ⬆️
... and 23 more

shmoradims
shmoradims approved these changes Apr 20, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

natke
natke approved these changes Apr 20, 2019
View reviewed changes
@codemzs codemzs merged commit bbae748 into dotnet:master Apr 20, 2019
@codemzs codemzs added the documentation Related to documentation of ML.NET label Apr 22, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfilipi sfilipi Awaiting requested review from sfilipi

3 more reviewers

@wschin wschin wschin left review comments

@natke natke natke approved these changes

@shmoradims shmoradims shmoradims approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codemzs @natke @wschin @shmoradims